Indexing of messages.timestamp to avoid runtime-copy. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended SqliteStorage::initialize() to add an index for the message table's timestamp column. Without this, the ORDER BY query in prepare_for_reading() causes expensive table duplication, which also has potential for out-of-disk or out-of-memory errors.
|
Thanks for the patch. Sounds extremely helpful. CI:
As a note: We require a DCO authentication for ROS2 repos. Do you mind signing your commit? It's sufficient to put |
Karsten1987
approved these changes
May 20, 2019
|
I'll go ahead and merge this wo/ DCO because I would like to have this in the pre-release for dashing. |
|
Thanks for the quick merge. Thumbs up! |
ruffsl
added a commit
to dledr/bbr_ros2
that referenced
this pull request
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended SqliteStorage::initialize() to add an index for the message table's timestamp column.
Without this, the ORDER BY query in SqliteStorage::prepare_for_reading() causes expensive table duplication, which also has potential for out-of-memory errors.