Patch zstd 1.4.4 to include cmake_minimum_version bump to 2.8.12 #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
requested review from
thomas-moulard and
jikawa-az
and removed request for
a team
|
clalancette
approved these changes
Dec 5, 2020
zmichaels11
approved these changes
Dec 6, 2020
delete-merged-branch
bot
deleted the
emersonknapp/zstd_cmake_minimum_required
branch
jacobperron
pushed a commit
that referenced
this pull request
Dec 14, 2020
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
jacobperron
added a commit
that referenced
this pull request
Dec 23, 2020
… (#587) Signed-off-by: Emerson Knapp <eknapp@amazon.com> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
ivanpauno
reviewed
Mar 24, 2021
| ${extra_cmake_args}) | ||
| ${extra_cmake_args} | ||
| # Note: zstd v1.4.6 will include the following fix. When that is released, upgrade and remove this patch. | ||
| PATCH_COMMAND patch -p1 -d . < ${CMAKE_CURRENT_SOURCE_DIR}/cmake_minimum_required_2.8.12.patch) |
There was a problem hiding this comment.
should something like in https://github.com/ros2/rviz/blob/2206b9257716c05dc4d5eaa7ffae12e434f151ca/rviz_ogre_vendor/CMakeLists.txt#L157 be done here?
when setting up a windows machine for debugging an issue, I needed to install patch from choco but the places that were using find_package(Patch) were working
There was a problem hiding this comment.
#632 is the planned solution, which should also work well without this dependency
There was a problem hiding this comment.
Sounds good, we will need something like that before the Galactic release as the current build from source instructions doesn't seem to be working on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #573
This eliminates CMake warnings on the Windows build (see https://ci.ros2.org/job/ci_windows/13244/cmake/#issuesContent)
We can remove the patch when a new zstd version gets released