Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing spaces to error message #875

Merged
merged 1 commit into from Oct 7, 2021
Merged

Add missing spaces to error message #875

merged 1 commit into from Oct 7, 2021

Conversation

jacobperron
Copy link
Member

A small improvement to the output.

@jacobperron
Add missing spaces to error message
ba3fd5b 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron requested a review from a team as a code owner October 4, 2021 20:28
@jacobperron jacobperron requested review from Karsten1987 and jhdcs and removed request for a team October 4, 2021 20:28
@jacobperron
Copy link
Member Author

The failed test looks unrelated to this PR:

2021-10-04T21:19:03.5035459Z The following tests FAILED:
2021-10-04T21:19:03.5036396Z 	 20 - test_play_timing__rmw_fastrtps_cpp (Failed)

...

2021-10-04T21:19:03.2424745Z 20: /__w/rosbag2/rosbag2/ros_ws/src/1zkpxfuagbl/rosbag2/rosbag2_transport/test/rosbag2_transport/test_play_timing.cpp:172: Failure
2021-10-04T21:19:03.2425634Z 20: Value of: replay_time
2021-10-04T21:19:03.2426605Z 20: Expected: is > 16-byte object <D0-2A C4-A6 18-56 00-00 00-BC A0-65 01-00 00-00>
2021-10-04T21:19:03.2429087Z 20:   Actual: 16-byte object <D0-2A C4-A6 18-56 00-00 2C-9D 9D-65 01-00 00-00> (of type rclcpp::Duration)
2021-10-04T21:19:03.2430061Z 20: [  FAILED  ] PlayerTestFixture.playing_respects_delay (6037 ms)

@clalancette
Copy link
Contributor

That may be a flaky test; that one didn't fail on #877 , for instance. I'm going to re-run it to see if I can get it to pass.

@clalancette
Copy link
Contributor

This just needs CI, then I think it can be merged.

@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron self-assigned this Oct 7, 2021
@clalancette
Copy link
Contributor

Looks good to me, merging.

@clalancette clalancette merged commit 2977a7b into master Oct 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the jacob/add_missing_space branch October 7, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@prajakta-gokhale prajakta-gokhale prajakta-gokhale approved these changes

@jhdcs jhdcs jhdcs approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987 Karsten1987 is a code owner automatically assigned from ros2/tooling-reviewers

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacobperron @clalancette @prajakta-gokhale @jhdcs