Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unordered map instead of map #65

merged 1 commit into from Nov 29, 2018


None yet
3 participants
Copy link

commented Nov 28, 2018

Replaces the usage of std::map with std::unordered_map where possible.

This pr is based on #57.

Only the last commit is actually part of this pr.

@Karsten1987 Karsten1987 force-pushed the bsinno:feature/use_unordered_map branch from 2844fa2 to 86043b7 Nov 29, 2018

@Karsten1987 Karsten1987 merged commit df4a4e0 into ros2:master Nov 29, 2018

@Karsten1987 Karsten1987 removed the in review label Nov 29, 2018

@anhosi anhosi deleted the bsinno:feature/use_unordered_map branch Nov 29, 2018

sriramster pushed a commit to sriramster/rosbag2 that referenced this pull request Feb 28, 2019

Record all topics (ros2#30)
* ros2GH-23 Get all topics from node and sanitize

* ros2GH-23 Move methods to node for better interface

* ros2GH-23 Use rmw_serialized_message_t consistently

* ros2GH-23 Improve santization of topics

* ros2GH-65 Introduce and use better logging macros

* ros2GH-23 Use publisher to serialized message directly

* ros2GH-23 Improve readability of sanitizing topics and types

* ros2GH-23 Allow to write all available topics

* ros2GH-23 Add test for record all

* ros2GH-23 Cleanup: add missing const ref to record interface

* Cleanup for doxygen

* Improve topic sanitization

- correctly expand topic names using rcl
- do not check type correctness (supposed to be done internally)

* Pass topic_name by reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.