New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed dependency to ros1_bridge package #90
removed dependency to ros1_bridge package #90
Conversation
* checking if package is available * if not skipping (with warnings) * now rosbag2_tests builds on systems without ros1
@DensoADAS thanks for the patch. I hope you don't mind me editing your original description for this PR. I connected it to the open issue so that our waffle board picks it up correctly and automatically closes the referenced issue when this PR is merged. extremely helpful patch. Running CI on it: I believe the cmake warning has to be turned into |
new round of CI, disabling that being said, I would really appreciate if we could use this PR to extend the same logic to the two excluded packages so that this complete repo can actually be built without any ros1 dependency. |
Looking at the latest CI, this patch is not sufficient. Looks like we should patch the two packages in question as well in . order to run CI correctly. |
check ros1 deps correctly on all packages
depends on ros2/ros1_bridge#164 |
message(WARNING "Failed to find PkgConfig, skipping...") | ||
# include bridge first to not create package if ros1 packages cannot be found | ||
find_package(ros1_bridge QUIET) | ||
if (NOT ros1_bridge_FOUND) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (NOT ros1_bridge_FOUND) | |
if(NOT ros1_bridge_FOUND) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* removed dependency to ros1_bridge package (#90) * removed dependency to ros1_bridge package: * checking if package is available * if not skipping (with warnings) * now rosbag2_tests builds on systems without ros1 * check ros1 deps correctly on all packages * add ros1_bridge to test package * silently try to find the bridge * correct missing linter errors (#96) Signed-off-by: Karsten Knese <karsten@openrobotics.org>
fixes #85
removed dependency to ros1_bridge package: