Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct missing linter errors #96

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
1 participant
@Karsten1987
Copy link
Contributor

commented Mar 25, 2019

for visibility only. Merging straight ahead.
connects to #90 (comment)

Signed-off-by: Karsten Knese karsten@openrobotics.org

correct missing linter errors
Signed-off-by: Karsten Knese <karsten@openrobotics.org>

@Karsten1987 Karsten1987 self-assigned this Mar 25, 2019

@Karsten1987 Karsten1987 merged commit d630f8e into master Mar 25, 2019

@Karsten1987 Karsten1987 deleted the fix_linter_errors branch Mar 25, 2019

Karsten1987 added a commit that referenced this pull request Apr 8, 2019

[backport] ros1 dependency handling (#98)
* removed dependency to ros1_bridge package (#90)

* removed dependency to ros1_bridge package:
 * checking if package is available
 * if not skipping (with warnings)
 * now rosbag2_tests builds on systems without ros1

* check ros1 deps correctly on all packages

* add ros1_bridge to test package

* silently try to find the bridge

* correct missing linter errors (#96)

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.