Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] ros1 dependency handling #98

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@Karsten1987
Copy link
Contributor

commented Apr 8, 2019

for visibility only

DensoADAS and others added some commits Mar 25, 2019

removed dependency to ros1_bridge package (#90)
* removed dependency to ros1_bridge package:
 * checking if package is available
 * if not skipping (with warnings)
 * now rosbag2_tests builds on systems without ros1

* check ros1 deps correctly on all packages

* add ros1_bridge to test package

* silently try to find the bridge
correct missing linter errors (#96)
Signed-off-by: Karsten Knese <karsten@openrobotics.org>

@Karsten1987 Karsten1987 merged commit dae2dad into crystal Apr 8, 2019

1 check failed

Cpr__rosbag2__ubuntu_bionic_amd64 Build finished.
Details

@Karsten1987 Karsten1987 removed the in progress label Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.