Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make diff minimal when migrating msg packages from ROS1 to ROS2 #270

Open
mikaelarguedas opened this issue Apr 17, 2018 · 0 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mikaelarguedas
Copy link
Member

When porting message packages from ROS1 to ROS2 recently I noticed that the CMake diff is so important that it's hard to see the relevant bits (how to use rosidl API and export dependencies).
It would be great to make the diff minimal for at least the message listing part.
Several possibilities:

  • modify ROS1 "add_message_files"/"add_service_files" to take accept an empty DIRECTORY and to be passed a relative path for messages (MyMessage -> "msg/MyMessage")
  • provide a utility in ROS 2 to concatenate a subdirectory string (eg msg) to each a list of message names

Both these options should allow to use the same list of messages and reduce the diff to how this list is passed to the message generation API.
There may be other alternatives, these 2 are the first ones that came to mind

@mikaelarguedas mikaelarguedas added the enhancement New feature or request label Apr 17, 2018
@mikaelarguedas mikaelarguedas added this to the bouncy milestone Apr 17, 2018
@mikaelarguedas mikaelarguedas removed this from the bouncy milestone May 7, 2018
@mikaelarguedas mikaelarguedas added the help wanted Extra attention is needed label May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant