Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy] Fix parsing of small floats #554

Merged
merged 1 commit into from Nov 17, 2020
Merged

Conversation

jacobperron
Copy link
Member

Backport #542 to Foxy.

The problem comes about because the msg -> idl transformer
can generate IDL defaults like "9e-05", which the lark
grammar wasn't ready to handle.  But Lark provides a FLOAT
terminal type, which *does* handle it, so use that instead.

Also add tests for floating point.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 4 via automation Nov 16, 2020
@jacobperron jacobperron moved this from Proposed to Needs release in Foxy Patch Release 4 Nov 16, 2020
@jacobperron
Copy link
Member Author

jacobperron commented Nov 16, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Edit: test failures and warnings are known and unrelated to this change.

@jacobperron jacobperron merged commit 97486a1 into foxy Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/foxy_backport_542 branch November 17, 2020 19:51
@jacobperron jacobperron moved this from Needs release to Released in Foxy Patch Release 4 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants