From f57fa102a7b5e8aa212695bb51187f8585992dcc Mon Sep 17 00:00:00 2001 From: dhood Date: Mon, 9 Jul 2018 09:37:48 +1000 Subject: [PATCH 1/2] Ignore warning for builtins A003 --- rosidl_generator_py/resource/_msg.py.em | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/rosidl_generator_py/resource/_msg.py.em b/rosidl_generator_py/resource/_msg.py.em index 73708039..8ed99a1a 100644 --- a/rosidl_generator_py/resource/_msg.py.em +++ b/rosidl_generator_py/resource/_msg.py.em @@ -175,7 +175,15 @@ class @(spec.base_type.type)(metaclass=Metaclass): return True @[for field in spec.fields]@ +@{ +import inspect +import builtins +}@ +@[if field.name in dict(inspect.getmembers(builtins)).keys()]@ + @@property # noqa: A003 +@[else]@ @@property +@[end if]@ def @(field.name)(self): """Message field '@(field.name)'.""" return self._@(field.name) From 8356153838de346a25f5a17cba6a0ae1f0854641 Mon Sep 17 00:00:00 2001 From: dhood Date: Mon, 9 Jul 2018 15:16:21 +1000 Subject: [PATCH 2/2] noqa setter also --- rosidl_generator_py/resource/_msg.py.em | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/rosidl_generator_py/resource/_msg.py.em b/rosidl_generator_py/resource/_msg.py.em index 8ed99a1a..676ea590 100644 --- a/rosidl_generator_py/resource/_msg.py.em +++ b/rosidl_generator_py/resource/_msg.py.em @@ -178,17 +178,16 @@ class @(spec.base_type.type)(metaclass=Metaclass): @{ import inspect import builtins +noqa_string = '' +if field.name in dict(inspect.getmembers(builtins)).keys(): + noqa_string = ' # noqa: A003' }@ -@[if field.name in dict(inspect.getmembers(builtins)).keys()]@ - @@property # noqa: A003 -@[else]@ - @@property -@[end if]@ + @@property@(noqa_string) def @(field.name)(self): """Message field '@(field.name)'.""" return self._@(field.name) - @@@(field.name).setter + @@@(field.name).setter@(noqa_string) def @(field.name)(self, value): if __debug__: @[ if not field.type.is_primitive_type()]@