Migrate LaserScanDisplay #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntCloud no longer exists
|
CI including the two additional repositories:
|
|
I resolved the conflicts in this pr and made a pr for adding the new repositories: ros2/ros2#477 Here's a new CI:
|
wjwwood
approved these changes
Mar 31, 2018
rviz_default_plugins/CMakeLists.txt
Outdated
| @@ -117,9 +120,11 @@ target_link_libraries(rviz_default_plugins | |||
| rviz_rendering::rviz_rendering | |||
| rviz_common::rviz_common | |||
| resource_retriever::resource_retriever | |||
| laser_geometry::laser_geometry | |||
There was a problem hiding this comment.
nitpick: alphabetical order unless the library order matters (I don't think it does)
rviz_default_plugins/package.xml
Outdated
| @@ -32,6 +32,7 @@ | |||
| <depend>rviz_rendering</depend> | |||
| <depend>urdf</depend> | |||
| <depend>visualization_msgs</depend> | |||
| <depend>laser_geometry</depend> | |||
wjwwood
added
in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that ros-perception/laser_geometry#28 has been merged we can migrate the LaserScanDispay to RViz2.
Requirement:
ros/angles:ros2andros-perception/laser_geometry:ros2must be added to ros2.repos before merging.Resolves #79.