Added covariance settings to set pose estimate #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin-Idel
reviewed
Jul 1, 2020
rviz_default_plugins/src/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.cpp
Show resolved
Hide resolved
|
How can I fix the tests? They appear to be unrelated with these changes. |
mdtoom
force-pushed
the
set_pose_with_covariance
branch
from
16dab40
to
0078ffb
Compare
jacobperron
reviewed
Jul 27, 2020
rviz_default_plugins/include/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.hpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.cpp
Outdated
Show resolved
Hide resolved
mdtoom
force-pushed
the
set_pose_with_covariance
branch
from
0078ffb
to
c26ebcf
Compare
|
You are right, my bad, I did not completely understand how to read the test report. |
|
Running CI for other platforms:
|
jacobperron
reviewed
Jul 28, 2020
rviz_default_plugins/src/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.cpp
Outdated
Show resolved
Hide resolved
mdtoom
force-pushed
the
set_pose_with_covariance
branch
from
c26ebcf
to
5d6932a
Compare
|
Windows: |
|
@mdtoom Thanks for iterating and for the feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds the possibility to change the covariance for the 2d pose estimation button in rviz.