Export Qt5 dependencies properly #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
force-pushed
the
hidmic/export-qt5-dependency
branch
from
ec1dfe5
to
ea3fea8
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/export-qt5-dependency
branch
from
ea3fea8
to
3b029d0
Compare
jacobperron
approved these changes
May 13, 2021
hidmic
added a commit
that referenced
this pull request
Oct 29, 2021
* Export Qt5 as rviz_default_plugins dependency properly * Export Qt5 as rviz_rendering dependency properly Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
added a commit
that referenced
this pull request
Nov 8, 2021
jacobperron
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Export Qt5 as rviz_default_plugins dependency properly * Export Qt5 as rviz_rendering dependency properly Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
jacobperron
added a commit
that referenced
this pull request
Feb 3, 2022
* Export Qt5 dependencies properly (#687) * Export Qt5 as rviz_default_plugins dependency properly * Export Qt5 as rviz_rendering dependency properly Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Lint Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies
rviz_renderingandrviz_default_pluginspackages to export Qt5's Widgets component as a dependency.CI up to
rviz_default_pluginsandrviz_rendering_tests: