Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GridCellsDisplay #286

Merged
merged 14 commits into from Jun 14, 2018

Conversation

Projects
None yet
4 participants
@botteroa-si
Copy link

botteroa-si commented Jun 8, 2018

Closes #96.

This PR includes the migration and refactoring of the GridCellsDisplay, with the addition of tests for it and of a visual test.

@wjwwood wjwwood added the in review label Jun 8, 2018

@botteroa-si

This comment has been minimized.

Copy link
Author

botteroa-si commented Jun 8, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@botteroa-si botteroa-si force-pushed the bsinno:feature/migrate_grid_cells_display branch from 3182571 to 9c80303 Jun 13, 2018

@botteroa-si

This comment has been minimized.

Copy link
Author

botteroa-si commented Jun 13, 2018

New CI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
/**
* \class GridCellsDisplay
* \brief Displays a nav_msgs::GridCells message
*/
class GridCellsDisplay : public Display
class RVIZ_DEFAULT_PLUGINS_PUBLIC GridCellsDisplay : public
rviz_common::RosTopicDisplay<nav_msgs::msg::GridCells>

This comment has been minimized.

Copy link
@wjwwood

wjwwood Jun 14, 2018

Member

This is really strange, but if that's what uncrustify wants to do...

@wjwwood wjwwood merged commit 2ffa05f into ros2:ros2 Jun 14, 2018

@clalancette clalancette removed the in review label Jun 14, 2018

@anhosi anhosi deleted the bsinno:feature/migrate_grid_cells_display branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.