Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ThirdPersonFollowerViewController #295

Merged

Conversation

Projects
None yet
4 participants
@greimela-si
Copy link

greimela-si commented Jun 13, 2018

This PR migrates the ThirdPersonFollowerViewController to ros2/rviz.
Closes #220.

Note: The first commit contains the required fix from #293, remove this commit after the fix has been merged!

@wjwwood wjwwood added the in review label Jun 13, 2018

@greimela-si

This comment has been minimized.

Copy link
Author

greimela-si commented Jun 13, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@greimela-si greimela-si changed the title Migrate third person follower view controller Migrate ThirdPersonFollowerViewController Jun 13, 2018

@wjwwood wjwwood added in progress and removed in review labels Jun 14, 2018

@anhosi anhosi force-pushed the bsinno:feature/migrate_third_person_follower_view_controller branch from d081088 to 7b3fd24 Jun 14, 2018

@anhosi

This comment has been minimized.

Copy link

anhosi commented Jun 14, 2018

New CI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
@anhosi

This comment has been minimized.

Copy link

anhosi commented Jun 14, 2018

@wjwwood We added the last commit (7b3fd24) only the make the tests pass. This commit resolves an undetected merge error from last night and will be published as a pr of its own. The last commit will cause a conflict once the other pr is merged. Simply remove the last commit from this pr before merging will work.

@Martin-Idel-SI Martin-Idel-SI referenced this pull request Jun 14, 2018

Merged

Add help again #300

@wjwwood wjwwood added in review and removed in progress labels Jun 15, 2018

@wjwwood wjwwood merged commit 3d82b49 into ros2:ros2 Jun 15, 2018

@wjwwood wjwwood removed the in review label Jun 15, 2018

@Martin-Idel-SI Martin-Idel-SI deleted the bsinno:feature/migrate_third_person_follower_view_controller branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.