Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for bouncy leveraging remapping for demo #53

Merged
merged 7 commits into from Jun 28, 2018

Conversation

Projects
None yet
3 participants
@dhood
Copy link
Member

commented Jun 22, 2018

@mikaelarguedas can you review please and if it looks good we can propagate to the other platform docs.

@dhood dhood added the in progress label Jun 22, 2018

@dhood dhood self-assigned this Jun 22, 2018

@dhood dhood requested a review from mikaelarguedas Jun 22, 2018

@mikaelarguedas
Copy link
Contributor

left a comment

change looks good 👍, we can propagate it to the other platforms.

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2018

@dhood when iterating on this it would be great to add a link to the "to be filled" Install-Connext-Security-Plugins wiki page.

@dhood

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2018

yep will do!

@dhood dhood force-pushed the readme_updates_bouncy branch from f00306e to 4f98d78 Jun 25, 2018

@dhood dhood added in review and removed in progress labels Jun 25, 2018

@dhood dhood requested a review from mikaelarguedas Jun 25, 2018

However, other nodes will not be able to communicate, e.g. the following invocation will fail to start a node with a name that is not associated with valid keys/certificates:

```bash
# This will fail because the node name does not have valid keys/certificates

This comment has been minimized.

Copy link
@ruffsl

ruffsl Jun 25, 2018

Member

Clarification: This would fail given the node would then be requesting system topics for a namespace it wasn't provisioned in the Secure DDS atricats, i.e. that include not_talker in the namespace, not necessary because the node's name is directly attributed into the public certificate itself, e.g. its common name or otherwise. Or has this changed?

This comment has been minimized.

Copy link
@mikaelarguedas

mikaelarguedas Jun 28, 2018

Contributor

This will actually fail because the namespace in the keystore doesnt exist so it wouldnt even go to the state of checking permissions but fail at the higher level saying "these files don't exist".

Regarding the name matching the common name, I think the current implementation would work as I believe the matching of the common name is done on the name prior to remapping (aka talker) though the permissions (if not wildcard) will not match the topics created after participant initialization as these will use the remapped node name

@mikaelarguedas
Copy link
Contributor

left a comment

lgtm, thanks @dhood for the improvement!

@mikaelarguedas mikaelarguedas merged commit 6752640 into master Jun 28, 2018

@mikaelarguedas mikaelarguedas deleted the readme_updates_bouncy branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.