Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sros2 cli test folder location #83

Merged
merged 2 commits into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@ruffsl
Copy link
Member

commented Feb 21, 2019

I'm not sure how only these rename and rm commits got dropped from my rebasing of #72 .
These are the only changes that had rebase differ from the PR commits prior to rebasing.

ruffsl added some commits Feb 21, 2019

Update test folder location
fixing incomplete rebase from #72
Remove old yaml profile examples
fixing incomplete rebase from #72

@ruffsl ruffsl added the in progress label Feb 21, 2019

@ruffsl ruffsl requested a review from mjcarroll Feb 21, 2019

@ruffsl ruffsl added in review and removed in progress labels Feb 21, 2019

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

lgtm, tests work for me with that branch 👍

Will there be a document replacing policy_definition.md?

@ruffsl

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

Will there be a document replacing policy_definition.md

I won't have time until the end of this month, but feel free to take a stab at it. Having a second person combe through the schema and templates would help in case I missed a corner case.

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

I won't have time until the end of this month, but feel free to take a stab at it.

Sounds good, I'll see if I find time to look into it.
Do you think this document is a requirement for the xml based policy to be part of the next Crystal patch release?

@ruffsl

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

Do you think this document is a requirement for the xml based policy to be part of the next Crystal patch release?

I'm not sure it would be a requirement, given the examples in the test folder are a bit self explanatory, but something short explaining the features of the namespacing parameters and permission flags might be helpful.

https://github.com/ros2/sros2/blob/master/SROS2_Linux.md#access-control

@mjcarroll mjcarroll merged commit d419f7b into master Feb 22, 2019

1 check passed

Cpr__sros2__ubuntu_bionic_amd64 Build finished.
Details

@mjcarroll mjcarroll deleted the xml_profile branch Feb 22, 2019

@mjcarroll mjcarroll removed the in review label Feb 22, 2019

mjcarroll added a commit that referenced this pull request Mar 8, 2019

[crystal-backport] Backport XML and XSLT functionality (#93)
* Correct sros2 cli test folder location (#83)

* Update test folder location
fixing incomplete rebase from #72

* Remove old yaml profile examples
fixing incomplete rebase from #72

* add reference to schema in generated permission files (#84)

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* Add missing attributes to test permissions XML file

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* fix status print to match commands invoked

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* Fix bug preventing generate_policy verb from working with publishers and services

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add CMake lint test to sros2_cmake (#90)

Fixed lint errors accordingly.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

@nuclearsandwich nuclearsandwich referenced this pull request Mar 13, 2019

Closed

Crystal Patch Release 3 #656

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.