Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test publishing a ConstSharedPtr #54

Merged
merged 1 commit into from
Oct 13, 2015
Merged

Test publishing a ConstSharedPtr #54

merged 1 commit into from
Oct 13, 2015

Conversation

jacquelinekay
Copy link
Contributor

Connects to ros2/rclcpp#123

Fixes ros2/rclcpp#118

Without the rclcpp pull request, this test fails to compile.

@jacquelinekay jacquelinekay added the in progress Actively being worked on (Kanban column) label Oct 13, 2015
@wjwwood
Copy link
Member

wjwwood commented Oct 13, 2015

+1

2 similar comments
@dirk-thomas
Copy link
Member

+1

@esteve
Copy link
Member

esteve commented Oct 13, 2015

+1

jacquelinekay added a commit that referenced this pull request Oct 13, 2015
@jacquelinekay
Merge pull request #54 from ros2/publish_const_shared_ptr
162381a 
Test publishing a ConstSharedPtr
@jacquelinekay jacquelinekay merged commit 162381a into master Oct 13, 2015
@jacquelinekay jacquelinekay removed the in progress Actively being worked on (Kanban column) label Oct 13, 2015
@jacquelinekay jacquelinekay deleted the publish_const_shared_ptr branch October 13, 2015 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacquelinekay @wjwwood @dirk-thomas @esteve