Make sure to fully initialize the QoS structures. #43
Conversation
There are additional structure members that were being left as garbage. Make sure to assign to a default before modifying the structure. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added
in progress
|
Can you please update the other uninitialized qos profiles in this repo ? (e.g. https://github.com/ros2/turtlebot2_demo/blob/master/turtlebot2_follower/src/follower.cpp#L117) |
|
Ah, good call. I took a brief look around, but must have missed that one. Will also update that. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Thanks for iterating on this. Did you cancel the job and rerun with the new changes or is it still the original jobs running ? |
|
It's still the original. I did a local build (which worked fine), and the new change is small enough that I didn't think it was worth doing another full build. Let me know if you want me to re-run the full CI. |
|
No I think we're good, these packages don't have tests anyway so CI is mostly checking for compiler warnings. If you successfully built it locally without warnings I think this is good to go |
|
Thanks @dhood . Merging. |
There are additional structure members that were being left
as garbage. Make sure to assign to a default before modifying
the structure.
This should fix: ros2/rosdistro#5
CI: