rename depth_to_pointcloud to depthimage_to_pointcloud2 #50
Conversation
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@nuclearsandwich FYI: that means the the previous deb will not be used for anything else than beta2 (we may decide it to remove it from the repos for the next release) and that a new deb will be generated for this package next time we bloom. |
👍 |
@@ -35,11 +35,12 @@ def launch(launch_descriptor, argv): | |||
name='astra_camera_node', | |||
exit_handler=restart_exit_handler, | |||
) | |||
package = 'depth_to_pointcloud' | |||
package = 'depthimage_to_poincloud2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "depthimage_to_pointcloud2"
name='depth_to_pointcloud_node', | ||
get_executable_path( | ||
package_name=package, executable_name='depthimage_to_poincloud2_node')], | ||
name='depthimage_to_poincloud2_node', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in this block.
typo fixed in b9d771b |
To be merged after beta2 announcement
Fixes #35