Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

rename depth_to_pointcloud to depthimage_to_pointcloud2 #50

Merged
merged 1 commit into from Jul 7, 2017

Conversation

mikaelarguedas
Copy link
Member

To be merged after beta2 announcement

Fixes #35

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jul 4, 2017
@mikaelarguedas
Copy link
Member Author

ready for review

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 6, 2017
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nuclearsandwich nuclearsandwich changed the title rename depth_to_pointcloud to dephimage_to_pointcloud2 rename depth_to_pointcloud to depthimage_to_pointcloud2 Jul 7, 2017
@mikaelarguedas
Copy link
Member Author

@nuclearsandwich FYI: that means the the previous deb will not be used for anything else than beta2 (we may decide it to remove it from the repos for the next release) and that a new deb will be generated for this package next time we bloom.

@mikaelarguedas mikaelarguedas merged commit d86c82b into master Jul 7, 2017
@mikaelarguedas mikaelarguedas deleted the rename_depth_to_pointcloud branch July 7, 2017 17:10
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jul 7, 2017
@nuclearsandwich
Copy link
Member

@nuclearsandwich FYI: that means the the previous deb will not be used for anything else than beta2 (we may decide it to remove it from the repos for the next release) and that a new deb will be generated for this package next time we bloom.

👍

@@ -35,11 +35,12 @@ def launch(launch_descriptor, argv):
name='astra_camera_node',
exit_handler=restart_exit_handler,
)
package = 'depth_to_pointcloud'
package = 'depthimage_to_poincloud2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "depthimage_to_pointcloud2"

name='depth_to_pointcloud_node',
get_executable_path(
package_name=package, executable_name='depthimage_to_poincloud2_node')],
name='depthimage_to_poincloud2_node',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in this block.

@mikaelarguedas
Copy link
Member Author

typo fixed in b9d771b
thanks @clalancette for catching that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants