New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/roscopeco/ormdroid/issues/7 #8

Merged
merged 5 commits into from Jul 1, 2013

Conversation

Projects
None yet
3 participants
@Machinarius
Copy link
Contributor

Machinarius commented Jun 14, 2013

No description provided.

@nobre84

This comment has been minimized.

Copy link

nobre84 commented Jun 21, 2013

Hi, I tried your pull request and it was breaking the OrmDroid Sample App:

at com.roscopeco.ormdroid.Entity$EntityMapping.build(Entity.java:192)
at com.roscopeco.ormdroid.Entity.getEntityMapping(Entity.java:518)
at com.roscopeco.ormdroid.Query.(Query.java:109)
at com.roscopeco.ormdroid.Entity.query(Entity.java:544)
at com.roscopeco.ormsample.PeopleListActivity.refresh(PeopleListActivity.java:27)
at com.roscopeco.ormsample.PeopleListActivity.onStart(PeopleListActivity.java:44)

@roscopeco

This comment has been minimized.

Copy link
Owner

roscopeco commented Jun 23, 2013

Thanks, I will take a look at this and hopefully get it merged very soon!

@roscopeco roscopeco merged commit f4c5de7 into roscopeco:master Jul 1, 2013

@roscopeco

This comment has been minimized.

Copy link
Owner

roscopeco commented Jul 1, 2013

This is now merged, but with some changes:

  • Private fields are still unmapped by default, but can now be mapped with the forceMap attribute of @column (less invasive API change for existing users).
  • The non-integral primary key support has been dropped for now, as the rest of the library isn't ready for it - it introduces a number of subtle bugs in unexpected places (e.g. Entity#hashCode).

Thanks for the changes!

@Machinarius

This comment has been minimized.

Copy link
Contributor

Machinarius commented Jul 2, 2013

No problem man. Sorry if i broke etiquette or something, that was my very first commit to a non-personal project.

@roscopeco

This comment has been minimized.

Copy link
Owner

roscopeco commented on src/com/roscopeco/ormdroid/Entity.java in 39db725 Sep 1, 2013

See issue #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment