Fix not erroring out on a bad HTTP status code

Author: rossmacarthur

src/lock.rs

@@ -24,7 +24,7 @@ use walkdir::WalkDir;
 use crate::{
     config::{Config, ExternalPlugin, GitReference, InlinePlugin, Plugin, Source, Template},
     context::{LockContext as Context, Settings, SettingsExt},
-    util::{git, TempPath},
+    util::{self, git, TempPath},
 };
 
 /// The maximmum number of threads to use while downloading sources.
@@ -209,7 +209,7 @@ impl Source {
         }
 
         let mut response =
-            reqwest::blocking::get(url.clone()).with_context(s!("failed to download `{}`", url))?;
+            util::download(url.clone()).with_context(s!("failed to download `{}`", url))?;
         fs::create_dir_all(&dir).with_context(s!("failed to create dir `{}`", dir.display()))?;
         let mut temp_file = TempPath::new(&file);
         temp_file.write(&mut response).with_context(s!(

src/util.rs

@@ -9,6 +9,7 @@ use std::{
 
 use anyhow::{Context as ResultExt, Error, Result};
 use fs2::{lock_contended_error, FileExt};
+use url::Url;
 
 use crate::context::{Context, SettingsExt};
 
@@ -31,6 +32,11 @@ fn nuke_path(path: &Path) -> io::Result<()> {
     }
 }
 
+/// Download a remote file and handle status code errors.
+pub fn download(url: Url) -> reqwest::Result<reqwest::blocking::Response> {
+    Ok(reqwest::blocking::get(url)?.error_for_status()?)
+}
+
 /////////////////////////////////////////////////////////////////////////
 // PathExt trait
 /////////////////////////////////////////////////////////////////////////