Skip to content

lock --reinstall deletes first and clones later #99

@dead10ck

Description

@dead10ck

It appears the lock --reinstall command will first delete all the existing directories, and then try to re-clone them:

https://github.com/rossmacarthur/sheldon/blob/master/src/lock.rs#L169-L176

This is unsafe, as cloning can fail, which will leave the user without any of their plugins. It should instead clone to a temporary directory, and then once everything is successful, then delete the existing directories and move the temporary ones into place.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementInternal improvements

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions