Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Proxy Options in with_fetch_options function #116

Merged
merged 3 commits into from Mar 26, 2021
Merged

Adds Proxy Options in with_fetch_options function #116

merged 3 commits into from Mar 26, 2021

Conversation

iclac
Copy link
Contributor

@iclac iclac commented Mar 25, 2021

Hi Ross, I need to use Sheldon behind an http proxy so I've had to add git2's ProxyOptions to handle this. Maybe my changes could be usefull to someone else, so my pull request...

Thanks for having create Sheldon: it is great!
claudio

Copy link
Owner

@rossmacarthur rossmacarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thanks for your contribution! Just some small comments, but I am happy to add this.

src/util.rs Outdated Show resolved Hide resolved
src/util.rs Outdated Show resolved Hide resolved
iclac and others added 2 commits March 25, 2021 22:09
Co-authored-by: Ross MacArthur <ross@macarthur.io>
@rossmacarthur rossmacarthur merged commit 4bb3977 into rossmacarthur:master Mar 26, 2021
@rossmacarthur
Copy link
Owner

Thanks!

@rossmacarthur
Copy link
Owner

This will go out in Sheldon v0.6.3, I'll most likely do a release this weekend.

@iclac
Copy link
Contributor Author

iclac commented Mar 26, 2021

Great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants