Skip to content

Release Profile Optimisations#145

Merged
rossmacarthur merged 2 commits into
rossmacarthur:trunkfrom
mkroli:release_profile
Oct 24, 2022
Merged

Release Profile Optimisations#145
rossmacarthur merged 2 commits into
rossmacarthur:trunkfrom
mkroli:release_profile

Conversation

@mkroli

@mkroli mkroli commented Jul 10, 2022

Copy link
Copy Markdown
Contributor

This contains settings for the release profile which decreases the binary size from ~12M to ~4M on my machine.

@rossmacarthur

rossmacarthur commented Oct 13, 2022

Copy link
Copy Markdown
Owner

Hi @mkroli, I don't think that binary size is necessarily the optimization that all users would benefit from. So with the exception of the strip flag I don't think we should change anything in the release profile. I am happy for an additional profile to be added that has these settings though, e.g. cargo install sheldon --profile compact. Alternatively, we could simply document the RUSTFLAGS that need to be set when running cargo install sheldon to accomplish this.

@rossmacarthur rossmacarthur merged commit 36b6cc9 into rossmacarthur:trunk Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants