Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable hooks in templates #150

Merged
merged 16 commits into from
May 16, 2023
Merged

Conversation

mkroli
Copy link
Contributor

@mkroli mkroli commented Sep 10, 2022

Resolves #126

@kitschpatrol
Copy link

kitschpatrol commented Apr 10, 2023

Anything blocking this PR? It would be super useful to keep plugin-specific config close to the associate plugin in the toml file.

(Also: Thanks for all the work that went into Sheldon, it's such a clean approach.)

Copy link
Owner

@rossmacarthur rossmacarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mkroli, thanks for the contribution. I have some small suggestions.

src/lock/script.rs Outdated Show resolved Hide resolved
src/lock/file.rs Outdated Show resolved Hide resolved
src/lock/mod.rs Outdated Show resolved Hide resolved
src/config/file.rs Outdated Show resolved Hide resolved
@rossmacarthur rossmacarthur merged commit c809255 into rossmacarthur:trunk May 16, 2023
@rossmacarthur
Copy link
Owner

Thanks!

@mkroli mkroli deleted the hooks branch August 8, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizing Variables
3 participants