problems with hash complies #9

Merged
merged 5 commits into from May 1, 2012

3 participants

@seamusabshere
Collaborator

this obviates #8

@rossmeissl rossmeissl was assigned Apr 30, 2012
@rossmeissl
Owner

When did this become a requirement?

@seamusabshere
Collaborator

you added it here - cda7973 - maybe @ihough knows why?

@rossmeissl
Owner

Oh right, because using GHG Protocol for, say, water impact doesn't make sense. That right, @ihough ?

@rossmeissl
Owner

Also, shame on me for not testing that . . . strange

@ihough
Collaborator

Right, it doesn't make sense for energy use or water impact to comply with GHG Protocol. Since we determine the compliance of an impact by checking which standards all committees complied with, if you add an energy use committee to an impact model the carbon impact will never comply with GHG Protocol.

@rossmeissl
Owner

OK so the complete discussion on complex compliance is in #4.

One big problem with your proposed failing test, Seamus, is that complex compliance only makes sense when we have a non-mastered decision (i.e., a decision that doesn't have an eponymous committee). And the Seamus object's can_i_commit_to_that_date decision, the one you've chosen to test, is mastered.

Regardless, this feature should be tested. Let me try to prove to you that it actually does work as intended.

@seamusabshere
Collaborator

i think my comments might actually be more important - both highlight what i believe to be typos/errors. feel free to dump test.

@rossmeissl
Owner

@seamusabshere plz take a look and make sure your concern is addressed here. Your comments were both right on.

@seamusabshere

compliance.superset?(guidelines) (if you were working with Sets)

Could do a full Set-based refactor . . . later

@seamusabshere

protocol, committees = pair ?

Done

@seamusabshere
Collaborator

looks good, i think you should merge

@rossmeissl rossmeissl merged commit 1c0a347 into master May 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment