Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Added support for multiple gaps operation #5

Merged
merged 1 commit into from

2 participants

@artemk

Using this commit you can use gap operation on multiple timeframes.

@rossmeissl
Owner

Thanks @artemk for the pull request!

Can you think of a nice way to do this without monkey-patching Array?

Like . . .

Timeframe.collection(timeframe1, timeframe2).gaps_left_by(timeframe3, timeframe4)

or something?

@artemk

of course i can, but this is more convenient way. Also it not monkey patching Array, but adding new method to open class.
Also that will be to many 'Timeframe' words :)

@artemk

anything new on this?

@rossmeissl
Owner

Haven't had time for the multiyear revamp yet, sadly. Will do ASAP.

On this pull request, I'm still uncomfortable with a mandatory core extension to Array. How about you make it optional? You can do this by just removing this line. Timeframe users who want this (fairly obscure, I think) additional functionality would just require 'timeframe/core_ext/array' in their own code.

That work for you?

@artemk artemk Merge pull request #1 from ignar/master
Add skip_year_boundary_crossing_check option to #crop
335ccda
@rossmeissl rossmeissl merged commit 335ccda into rossmeissl:master
@rossmeissl
Owner

Thanks again @artemk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 29, 2011
  1. @artemk

    Merge pull request #1 from ignar/master

    artemk authored
    Add skip_year_boundary_crossing_check option to #crop
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 0 deletions.
Something went wrong with that request. Please try again.