Skip to content
This repository has been archived by the owner. It is now read-only.

URL should not assume filename naming convention #6

Closed
haidangwa opened this issue Nov 24, 2015 · 3 comments

Comments

@haidangwa
Copy link
Collaborator

commented Nov 24, 2015

Can we turn the filename of the zip file into a configurable node attribute? We store our artifacts in a private Nexus repo, which gets renamed to a file with dashes (-) instead of underscores. https://github.com/rosstimson/chef-terraform/blob/master/recipes/default.rb#L24 prevents any override of this without using something like chef-rewind.

@rosstimson

This comment has been minimized.

Copy link
Owner

commented Dec 8, 2015

This should present now thanks to you work, thanks very much.

@rosstimson rosstimson closed this Dec 8, 2015
@haidangwa

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 8, 2015

Thanks for merging the code. Would you mind uploading it to Chef's
Supermarket? Since you aren't working with Chef much anymore, do you mind
adding me as a collaborator? I could carry the torch, per se.

On Tue, Dec 8, 2015, 2:41 PM Ross Timson notifications@github.com wrote:

This should present now thanks to you work, thanks very much.


Reply to this email directly or view it on GitHub
#6 (comment)
.

@rosstimson

This comment has been minimized.

Copy link
Owner

commented Dec 9, 2015

@haidangwa I've just pushed to the Supermarket now.

That would be awesome, thanks for the offer/help, I've added you as a collaborator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.