Add InstrumentationScope support to ResourceSpans#21
Merged
Conversation
mheffner
approved these changes
Apr 11, 2025
| // Careful observer will notice this looks like PyAttributes called from PyResource, however | ||
| // that class has additional ArcMutexes around the KeyValues. We tried out a new pattern here for the scope attributes | ||
| // and it appears to be working well. For the sake of safety I want to finish additional testing before going back and | ||
| // refactoring. WHen we do we should be able to remove this and share a single attributes and attributes iter type. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes: STR-3253
Adds support for
Optional<InstrumentationScope>to the ResourceSpans type. In this PR we use a new approach which reduces the need for an additional ArcMutex in the InstrumentationScope attributes property. So far this looks pretty good. In a future PR we will likely update ResourceAttributes to use a similar model and collapse the two.