Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Once eth accounts are read from the DB make sure they are EIP55 encoded #519

Closed
LefterisJP opened this issue Oct 15, 2019 · 0 comments
Closed

Once eth accounts are read from the DB make sure they are EIP55 encoded #519

LefterisJP opened this issue Oct 15, 2019 · 0 comments
Labels
good first issue Good for newcomers hacktoberfest Issues tagged for https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed

Comments

@LefterisJP
Copy link
Member

Problem Definition

There is a long-standing TODO here:

https://github.com/rotkehlchenio/rotkehlchen/blob/f3cf54acc22c9505b9d27d6b80c670a3609c2093/rotkehlchen/blockchain.py#L58-L61

It's to remove that ugly editing of the immutable named tuple of blockchain accounts.

Task

In order to remove the TODO what needs to be done is:

  1. Remove that line of code that edits the named tuple and the comment around it.
  2. Instead make sure that all ethereum addresses are EIP55 encoded once retrieved from the DB here: https://github.com/rotkehlchenio/rotkehlchen/blob/f3cf54acc22c9505b9d27d6b80c670a3609c2093/rotkehlchen/db/dbhandler.py#L698-L719
  3. Add a test for this
@LefterisJP LefterisJP added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Issues tagged for https://hacktoberfest.digitalocean.com/ labels Oct 15, 2019
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Dec 20, 2019
@LefterisJP
Do not force mutate eth accounts to be checksummed
97cf674 
Fix rotki#519.

This should no longer happen. The very first upgrade of the DB turned
all address entries into checksummed entries. Since then we make sure
to always add addresses as checksummed in the DB and the API also
makes sure that all address input is checksummed.

So this commit closes the chapter by warning the user if a
non-checksummed eth account is found in his DB. But the only way this
happens is if the user manually edits it.
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Dec 24, 2019
@LefterisJP
Do not force mutate eth accounts to be checksummed
dbca15d 
Fix rotki#519.

This should no longer happen. The very first upgrade of the DB turned
all address entries into checksummed entries. Since then we make sure
to always add addresses as checksummed in the DB and the API also
makes sure that all address input is checksummed.

So this commit closes the chapter by warning the user if a
non-checksummed eth account is found in his DB. But the only way this
happens is if the user manually edits it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Issues tagged for https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LefterisJP