Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to mypy 0740 and some type additions #524

Merged
merged 2 commits into from Oct 19, 2019

Conversation

LefterisJP
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #524 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   77.03%   77.07%   +0.04%     
==========================================
  Files          50       50              
  Lines        4890     4890              
  Branches      717      717              
==========================================
+ Hits         3767     3769       +2     
+ Misses        938      932       -6     
- Partials      185      189       +4
Impacted Files Coverage Δ
rotkehlchen/exchanges/exchange.py 93.69% <ø> (ø) ⬆️
rotkehlchen/accounting/accountant.py 86.42% <ø> (+4.52%) ⬆️
rotkehlchen/ethchain.py 55.76% <0%> (-2.57%) ⬇️
rotkehlchen/inquirer.py 90.06% <0%> (-2.49%) ⬇️
rotkehlchen/utils/misc.py 79.54% <0%> (-0.57%) ⬇️
rotkehlchen/server.py 59.88% <0%> (-0.29%) ⬇️
rotkehlchen/externalapis/cryptocompare.py 66.53% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0bbada...d2c8414. Read the comment docs.

@LefterisJP LefterisJP merged commit a78c138 into rotki:master Oct 19, 2019
@LefterisJP LefterisJP deleted the mypy_0740 branch October 19, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants