Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to load RMRK balance from Kucoin #3702

Closed
Swader opened this issue Nov 11, 2021 · 5 comments · Fixed by #3704
Closed

Fails to load RMRK balance from Kucoin #3702

Swader opened this issue Nov 11, 2021 · 5 comments · Fixed by #3704
Milestone

Comments

@Swader
Copy link

Swader commented Nov 11, 2021

Problem Definition

Adding a Kucoin account will fail to load one's RMRK balance with the following error:

image

@LefterisJP
Copy link
Member

Thanks for the issue @Swader. (Wasn't your username bitfalls?).

It's since we don't support RMRK yet and it's not mapped properly to kucoin.

So @yabirgb let's include that in the upcoming release too.

  1. Add support for https://www.coingecko.com/en/coins/rmrk
  2. Map it properly in Kucoin

@LefterisJP LefterisJP added this to the v1.22.0 milestone Nov 12, 2021
@Swader
Copy link
Author

Swader commented Nov 12, 2021

bitfalls on twitter, swader everywhere else :)

yabirgb added a commit to yabirgb/rotki that referenced this issue Nov 12, 2021
- RMRK Closes rotki#3702
- ROCO finance Closes rotki#3644
- GEL Closes rotki#3636
- Fixes Metis symbol
@javimurcia
Copy link

I'm still getting this error:
Found unsupported kucoin asset RMRK while deserializing a balance. Ignoring it.

When i originally had that error, i manually created the asset, but the error still persists. And after getting the update and starting from scrath, the error still persist.

This is the current config for the asset
image

@LefterisJP
Copy link
Member

I'm still getting this error: Found unsupported kucoin asset RMRK while deserializing a balance. Ignoring it.

When i originally had that error, i manually created the asset, but the error still persists. And after getting the update and starting from scrath, the error still persist.

This is the current config for the asset image

Hey @javimurcia. You are correct. We added the asset in v1.22.0 but it was in the unsupported assets list for kucoin and it was not removed from that list. That's a mistake on our side.

We are about to release v1.22.1. I am gonna sneak the one line fix for that in there. Should be out by end of this week. Btw, at this point you should not need to add the asset manually as it should already be in the asset database.

@LefterisJP LefterisJP reopened this Nov 18, 2021
@LefterisJP LefterisJP modified the milestones: v1.22.0, v1.22.1 Nov 18, 2021
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Nov 18, 2021
This is so that we don't add a mapping to a specific asset thinking we
have fixed the mapping but have also forgotten it in the unsupported
assets list like we did in this issue:
rotki#3702 (comment)
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Nov 18, 2021
@LefterisJP
Copy link
Member

Should hopefully now be fixed by #3734 and included in v1.22.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants