Fix update indicator #783
Fix update indicator #783
Conversation
Fixed version model in vue to match API response so that update incator shows properly.
There was a problem hiding this comment.
Looks good. Can you also add a changelog entry for this? It's here: https://github.com/rotki/rotki/blob/4698037766b306d29cea4925f2b38177232f389f/docs/changelog.rst
|
@kelsos can you also have a quick look? |
Codecov Report
@@ Coverage Diff @@
## develop #783 +/- ##
===========================================
+ Coverage 78.11% 79.54% +1.43%
===========================================
Files 86 71 -15
Lines 10040 7687 -2353
Branches 1466 1096 -370
===========================================
- Hits 7843 6115 -1728
+ Misses 1829 1329 -500
+ Partials 368 243 -125
Continue to review full report at Codecov.
|
added in new commit f56c7a9 Let me know if that's ok! |
docs/changelog.rst
Outdated
| @@ -2,6 +2,9 @@ | |||
| Changelog | |||
| ========= | |||
|
|
|||
| * :release:`1.2.2 <2020-03-xx>` 783 | |||
There was a problem hiding this comment.
Don't add a release above it. Just leave it empty as we don't know if it will be minor/patch or the date.
|
@isidorosp Can you combine the last two commits in one? Squash them together. |
* Added line for bug 783
|
I will merge despite the random OSX failure. It's nothing ... and it's one of the main reasons I am contemplating moving away from Travis CI. |
Addresses #781
Fixed
versionmodel in vue to match API response so that update indicator shows properly.