Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for date display format #305

Merged
merged 10 commits into from Mar 19, 2019
Merged

Add setting for date display format #305

merged 10 commits into from Mar 19, 2019

Conversation

@kelsos
Copy link
Collaborator

kelsos commented Feb 25, 2019

Closes #194

@kelsos

This comment has been minimized.

Copy link
Collaborator Author

kelsos commented Feb 26, 2019

It seems I have to do some timezone related tests to make sure that everything works properly.

@kelsos kelsos changed the title Add setting for display format Add setting for date display format Mar 3, 2019
@kelsos

This comment has been minimized.

Copy link
Collaborator Author

kelsos commented Mar 3, 2019

@LefterisJP can you review this PR?

Copy link
Contributor

LefterisJP left a comment

Hey @kelsos! Looking good. Just some extra changes needed in the backend.

@@ -75,6 +75,7 @@
'balance_save_frequency',
'anonymized_logs',
'include_gas_costs',
'date_display_format',

This comment has been minimized.

Copy link
@LefterisJP

LefterisJP Mar 9, 2019

Contributor

Hmm more changes are needed in the backend. You need to be able to return a default display format from the DB even if there is no value in there (for all people who have not yet upgraded to the changes of this PR).

Check here for how to achieve this:

https://github.com/rotkehlchenio/rotkehlchen/blob/master/rotkehlchen/db/dbhandler.py#L391-L433

And also change the tests here:

https://github.com/rotkehlchenio/rotkehlchen/blob/dbdee73c98bc55940069d911eeebb65ed9825f1a/rotkehlchen/tests/test_db.py#L143

kelsos added 10 commits Feb 17, 2019
[ui tests]
[ui tests]
[ui tests]
[ui tests]
[ui tests]
[ui tests]
[ui tests]
[ui tests]
@kelsos

This comment has been minimized.

Copy link
Collaborator Author

kelsos commented Mar 16, 2019

@LefterisJP Can you re-review the PR? or at least the latest changes? There was something weird happening with the CI yesterday but now tests seem to pass.

Copy link
Contributor

LefterisJP left a comment

Thank you @kelsos. Looking good!

@LefterisJP LefterisJP merged commit b40551d into rotki:master Mar 19, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@kelsos kelsos deleted the kelsos:add_setting_for_display_format branch Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.