Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Maintain a list of supported assets and a lot of refactorings #342
The mapping is added from scanning through kraken's assets. The key is the canonical symbol and it maps to an object with some data. The data include a name and a type. Optionally can included an "active": false entry if the asset is no longer active. They also may optionally include a "started" to state the timestamp at which the asset started. If not given it's assumed to be the epoch start. Also can optionally contain a "forked" entry showing that this asset forked from another asset. It can also optionally contain a swapped_for entry showing that this asset is now inactive but is swapped_for another asset
- Also add checks for active and type - Also change USDT type to omni token - Also change ICN's start_time
But it's still not used in the actual codebase. This is just the first step towards doing it. Also created the converters from/to cryptocompare.
- Also turn asset aggregator into a multi-file tool - Also now include coinmarketcap in the queries of the asset aggregator
- From now on, for poloniex some assets have a different canonical name (the name in Rotkehlchen) and a different one in Poloniex - Made some additions to the asset aggregator script - Also added a few more assets to the assets list
If that file is given then only the assets given by the input file are checked. This commit also categorized all poloniex assets until end of "G".
LefterisJP merged commit
May 14, 2019
2 of 3 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.