Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain a list of supported assets and a lot of refactorings #342

Merged
merged 125 commits into from May 14, 2019

Conversation

@LefterisJP
Copy link
Contributor

LefterisJP commented May 14, 2019

A lot of work to support #329 and a lot of refactorings alongside it

LefterisJP added 30 commits Mar 8, 2019
The mapping is added from scanning through kraken's assets. The key is
the canonical symbol and it maps to an object with some data.

The data include a name and a type. Optionally can included an
"active": false entry if the asset is no longer active. They also may
optionally include a "started" to state the timestamp at which the
asset started. If not given it's assumed to be the epoch start.

Also can optionally contain a "forked" entry showing that this asset
forked from another asset.

It can also optionally contain a swapped_for entry showing that this
asset is now inactive but is swapped_for another asset
Thanks for the name @rakanalh
- Also add checks for active and type
- Also change USDT type to omni token
- Also change ICN's start_time
But it's still not used in the actual codebase. This is just the first
step towards doing it.

Also created the converters from/to cryptocompare.
- Also turn asset aggregator into a multi-file tool
- Also now include coinmarketcap in the queries of the asset aggregator
- From now on, for poloniex some assets have a different canonical
  name (the name in Rotkehlchen) and a different one in Poloniex
- Made some additions to the asset aggregator script
- Also added a few more assets to the assets list
- Also add recognized coins from Poloniex including all the coins
  starting with 'B'
If that file is given then only the assets given by the input file are
checked.

This commit also categorized all poloniex assets until end of "G".
LefterisJP added 26 commits Apr 21, 2019
This upgrade changes the assets that are known to have changed with
the work on issue #329. So far the only asset that had definitely
changes is BCHSV to BSV.

For others, unless specifically seen by the time this PR is merged,
user action will be required
@LefterisJP LefterisJP merged commit e943cc2 into rotki:master May 14, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@LefterisJP LefterisJP deleted the LefterisJP:workon_329 branch May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.