Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rewrites the electron app in vue.js #371
Opening the PR to keep track of the work done on the vue - rewrite of the app.
Remaining tasks for the PR
@@ Coverage Diff @@ ## develop #371 +/- ## ========================================== Coverage ? 77.63% ========================================== Files ? 53 Lines ? 5143 Branches ? 751 ========================================== Hits ? 3993 Misses ? 948 Partials ? 202
LefterisJP left a comment
First of all huge thanks for putting so much work on this. You rock!
So I am doing an initial review of the functionality here by testing it with live data of a heavy user. I am not going to comment on things that work fine.
What I see that definitely needs fixing:
So I have an idea why the currency set/NAN happens if you check the header it says
The most curious thing is why it works locally. I remember seeing a change in the
OTC trades I am already aware it broke when I upgraded to the latest Vuetify, I already have it as a todo.
About the grid for the exchange icons should is the problem only with cointracking or is it something different?
On the progress bar, I had similar negative progress issues with the calculations on the retail, I have to re-evaluate.
on 3 the blockchain balances update together right? so the other missing balances are practically the exchange balances that are currently not displayed.
I will have to set it up and go again through the premium flow.
Statistics won't work at the moment due to the fact that they depend on the implementation details of the live version. I think I mentioned it before. But the last part of the rewrite after everything works is to also update the statistics.
Thanks for the feedback, I will finish the tests and then start fixing the current issues.
Cointracking? Cointracking is not an exchange. No this is only that in the previous version it was a grid. So three exchanges first row, three exchanges last row.
There used to be but I fixed it with a PR. So it either still is or somehow with the rewrite it relapsed.
Yes. But they have been queried since for example I can see them if I click on any exchange's icons.
@LefterisJP yes I meant coinbase, my mistake I was merging the coin tracking info import yesterday, thus the mistake
I will check master to be sure. Maybe when I implemented the progress the fix was not merged yet.
Yes, the problem is that I had no clue that exchange data were displayed there, so 3-4 is the same issue I just don't show them at all. It should be easy to modify the getter to include them
So I had another look as requested and will write out what I found.
Need to do pip install -e.
For some reason the electron app does not discover the python process without
Multiple balances of same asset in "All balances"
For some reason in the "all balances" table in the dashboard there are multiple entries for different assets. Perhaps since it does not sum up the locations (e.g. exchanges, blockchain, banks)?
Missing Grey out/Green out of exchange premium key if it's already registered.
In the current version if an exchange is already registered (also if premium is working) the respective api key/secret fields are green/greyed out so that the user knows he can't input a new key unless he presses the remove button.
Missing a way to provide tokens location per ETH account
In the original UI you could see how many/which tokens each account holds. It is indeed subtoptimal since for each token there was a new column in that table and as such became too big and needed scrolling. Perhaps as you suggested in our chat add it as hidden info per account that can be shown? You could have another column
Did not pick up the main currency from settings
The main currency of the account should have been
UI element has no padding
This is rather minor but the UI element of the start date does not seem to have enough distance from the "Main currency selection"
Editing a date should start from date that is being edited
I am trying to edit a date for a trade and wanted to make it 1 day later. But when clicking the UI element it starts from the current date. It should start from the date that is being edited.
Editing/deleting external trades does not work
Perhaps something wrong with a rebase? There were some changes there.
Data import margin/padding
Super minor ... but it looks ugly at the moment. There is no padding/margin to separate from the left and top menus.
Tax report warning
The new progress bar looks much better. I think it would be nice to have a message there too warning the user that this will probably take a lot of time if he has done many trades and/or if the period is long. One thing to keep in mind here is that the report will go through all trades/actions no matter when the user set the start period since it needs to know about all actions that happened.
Missing is_virtual marker from trades report
At some point there is some trades of selling BCH for BTC. That creates also a virtual trade of buying the equivalent BTC amount with EUR but there is nothing in the virtual column.
Looking at the new stuff I guess:
The ui of the api keys still does not really show that it's not inputtable. I indeed can't click on an exchange that is already registered but it's not really visible that it's greyed out. Something a bit more obvious would be nice. Does not need to be as much highlighted as it is in the current version.
I like the way the tokens show for the accounts now, but perhaps it should be a bit more obvious that they can be expanded. Not sure how. We should think on it.
One note though. The accounts that have no tokens should not be expandable. The arrow should be missing for them.
I also saw this warning in the dev tools:
The rest of the concerns of the last comment seem to be addressed.
@LefterisJP Could you have a look at the packaging and how it works for you?
To be safe rename/delete the
The build targets are dmg for macOS, a portable executable for Windows and a tar/AppImage for linux.
So from the premium statistics the only thing that I see is the order is wrong.
It should be:
Also the start date dropdown is kind of annoying as it insists to be provided time. If I start typing I want the calendar view to not hide the typing. And If I type "01/01/2016" and press Enter it should work and not tell me I have to enter the hour too.
After merging the latest premium components and continuing testing I noticed this warning in the console. It is emitted directly at the start of the app:
Also still as before letting the app query all blockchain balances seems to over-write the balances of an asset found in the exchanges. For example the test user had
Same for other assets, for example kraken EUR balances being overwritten by banks EUR balances, instead of getting added.
Finally for the premium statistics I would like some default values for the charts as they were before.
Hey @kelsos so I think that it's mostly working and we will need to iron out any other bugs we find. But at this point this should be merged to develop so that the other big change can also be rebased on top of it. Do you agree?
Can you add a changelog entry also? Since you are the author of the change choose the words, but try to focus on modern/sleek UI which is also easily customizable.