Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multicollateral DAI upgrade and Single Collateral DAI renaming to SAI #551

Merged
merged 6 commits into from Nov 26, 2019

Conversation

@LefterisJP
Copy link
Contributor

LefterisJP commented Nov 26, 2019

Fix #547

LefterisJP added 6 commits Nov 23, 2019
Fix #547
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #551 into master will increase coverage by 0.3%.
The diff coverage is 88.19%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #551     +/-   ##
=========================================
+ Coverage   76.08%   76.39%   +0.3%     
=========================================
  Files          64       65      +1     
  Lines        7118     7244    +126     
  Branches     1068     1085     +17     
=========================================
+ Hits         5416     5534    +118     
+ Misses       1411     1408      -3     
- Partials      291      302     +11
Impacted Files Coverage Δ
rotkehlchen/constants/cryptocompare.py 100% <ø> (ø) ⬆️
rotkehlchen/db/upgrade_manager.py 97.1% <100%> (+7.39%) ⬆️
rotkehlchen/db/settings.py 92.4% <100%> (ø) ⬆️
rotkehlchen/db/upgrades/v6_v7.py 67.64% <100%> (+10.72%) ⬆️
rotkehlchen/constants/assets.py 100% <100%> (ø) ⬆️
rotkehlchen/assets/converters.py 85.48% <46.66%> (-12.39%) ⬇️
rotkehlchen/exchanges/coinbase.py 65.1% <91.66%> (+0.12%) ⬆️
rotkehlchen/db/upgrades/v7_v8.py 92.38% <92.38%> (ø)
rotkehlchen/premium/sync.py 69.4% <0%> (-2.24%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc65da...ed796f0. Read the comment docs.

@LefterisJP LefterisJP merged commit b141776 into rotki:master Nov 26, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@LefterisJP LefterisJP deleted the LefterisJP:workon_547 branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.