Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to force-refresh balances, ignoring any caches #584

Merged
merged 7 commits into from Jan 1, 2020

Conversation

@LefterisJP
Copy link
Contributor

LefterisJP commented Dec 28, 2019

Fix #168

So far the backend work is done. Remaining is the front-end work.

LefterisJP added 3 commits Dec 27, 2019
- Also fix some api tests that had false assumptions.
- Also add API tests for ignoring the cache in the:
    * Blockchain balances endpoint
    * Exchange balances endpoint
    * All balances endpoint
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 28, 2019

Codecov Report

Merging #584 into develop will decrease coverage by 2.7%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #584      +/-   ##
===========================================
- Coverage    84.38%   81.68%   -2.71%     
===========================================
  Files           56       70      +14     
  Lines         5868     8081    +2213     
  Branches       810     1168     +358     
===========================================
+ Hits          4952     6601    +1649     
- Misses         714     1170     +456     
- Partials       202      310     +108
Impacted Files Coverage Δ
rotkehlchen/exchanges/binance.py 85.54% <100%> (ø)
rotkehlchen/exchanges/coinbase.py 65.23% <100%> (ø)
rotkehlchen/utils/misc.py 86.86% <100%> (-2.87%) ⬇️
rotkehlchen/utils/interfaces.py 100% <100%> (ø)
rotkehlchen/exchanges/kraken.py 67.16% <100%> (ø)
rotkehlchen/api/v1/encoding.py 97.97% <100%> (+0.01%) ⬆️
rotkehlchen/exchanges/poloniex.py 77.35% <100%> (ø)
rotkehlchen/blockchain.py 85.15% <100%> (ø)
rotkehlchen/api/rest.py 89.55% <100%> (+1.11%) ⬆️
rotkehlchen/rotkehlchen.py 75.91% <100%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48574f9...2291b03. Read the comment docs.

kelsos and others added 3 commits Dec 28, 2019
@LefterisJP

This comment has been minimized.

Copy link
Contributor Author

LefterisJP commented Dec 29, 2019

@kelsos I specified that it's only the balances that are force refreshed. Other than that it looks nice. I was wondering though what do you think about this:

2019-12-29-104126_956x164_scrot

The above refresh button does the same as the dashboard refresh. Perhaps we can somehow make it obvious that from here you can refresh only the ETH blockchain balances, or the BTC ones (..or whatever we have later) by selecting the appropriate one?

@LefterisJP LefterisJP merged commit 52b0415 into rotki:develop Jan 1, 2020
5 checks passed
5 checks passed
codecov/patch 100% of diff hit (target 84.38%)
Details
codecov/project Absolute coverage decreased by -2.7% but relative coverage increased by +15.61% compared to 48574f9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@LefterisJP LefterisJP deleted the LefterisJP:workon_168 branch Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.