From 5af079ea9fe2898c4dc817ae624c86e542979dfb Mon Sep 17 00:00:00 2001 From: Jean Felder Date: Mon, 24 Jun 2024 14:54:47 +0200 Subject: [PATCH] qgsframegraph: rename QRenderTarget in the ambient occlusion pass The output is the color buffer, not a depth one. --- src/3d/qgsframegraph.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/3d/qgsframegraph.cpp b/src/3d/qgsframegraph.cpp index 510d94c41a74..ca34ff607498 100644 --- a/src/3d/qgsframegraph.cpp +++ b/src/3d/qgsframegraph.cpp @@ -352,13 +352,13 @@ Qt3DRender::QFrameGraphNode *QgsFrameGraph::constructAmbientOcclusionRenderPass( mAmbientOcclusionRenderLayerFilter = new Qt3DRender::QLayerFilter( mAmbientOcclusionRenderStateSet ); mAmbientOcclusionRenderCaptureTargetSelector = new Qt3DRender::QRenderTargetSelector( mAmbientOcclusionRenderLayerFilter ); - Qt3DRender::QRenderTarget *depthRenderTarget = new Qt3DRender::QRenderTarget( mAmbientOcclusionRenderCaptureTargetSelector ); + Qt3DRender::QRenderTarget *colorRenderTarget = new Qt3DRender::QRenderTarget( mAmbientOcclusionRenderCaptureTargetSelector ); // The lifetime of the objects created here is managed // automatically, as they become children of this object. // Create a render target output for rendering color. - Qt3DRender::QRenderTargetOutput *colorOutput = new Qt3DRender::QRenderTargetOutput( depthRenderTarget ); + Qt3DRender::QRenderTargetOutput *colorOutput = new Qt3DRender::QRenderTargetOutput( colorRenderTarget ); colorOutput->setAttachmentPoint( Qt3DRender::QRenderTargetOutput::Color0 ); // Create a texture to render into. @@ -370,9 +370,9 @@ Qt3DRender::QFrameGraphNode *QgsFrameGraph::constructAmbientOcclusionRenderPass( // Hook the texture up to our output, and the output up to this object. colorOutput->setTexture( mAmbientOcclusionRenderTexture ); - depthRenderTarget->addOutput( colorOutput ); + colorRenderTarget->addOutput( colorOutput ); - mAmbientOcclusionRenderCaptureTargetSelector->setTarget( depthRenderTarget ); + mAmbientOcclusionRenderCaptureTargetSelector->setTarget( colorRenderTarget ); mAmbientOcclusionRenderEntity = new QgsAmbientOcclusionRenderEntity( mForwardDepthTexture, mMainCamera, mRootEntity ); mAmbientOcclusionRenderLayerFilter->addLayer( mAmbientOcclusionRenderEntity->layer() );