Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Biml Lexer support #415

Merged
merged 5 commits into from Jun 2, 2016
Merged

Initial Biml Lexer support #415

merged 5 commits into from Jun 2, 2016

Conversation

@japj
Copy link
Contributor

japj commented Mar 2, 2016

This is the initial support for BIML highlighting.

This initial version is based of the XML Lexer with the additional support for dealing with <# style parts and then delegating to the CSharp Lexer.

The only thing I have not figured out yet is how to correctly handle the embedded <# handling inside an xml attribute value string, i.e. (this one is currently rendered wrong).

I hope this is acceptable as a first version, if not then just let me know what needs to be fixed

@japj
Copy link
Contributor Author

japj commented Mar 2, 2016

Ok, I just discovered there might be an UTF8 encoding issue in the biml sample files, looking into that

@japj
Copy link
Contributor Author

japj commented Mar 2, 2016

Fixed the UTF8 issue in #417

@jneen
Copy link
Member

jneen commented Jun 2, 2016

Awesome, this looks great! Just two things before I merge:

  • Please use 2-space indentation for all the ruby files.
  • Please add newlines at the end of each file.
@japj
Copy link
Contributor Author

japj commented Jun 2, 2016

Thanks for the feedback and sorry for not catching that myself earlier.
I updated the pull request, but apparently the utf8 fix got pulled into this aswell.
I don't think that should be a problem though since you already merged it?

@jneen
Copy link
Member

jneen commented Jun 2, 2016

Should be fine. Worst case is an extra no-op commit.

@jneen jneen merged commit 8186ad6 into rouge-ruby:master Jun 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jneen
Copy link
Member

jneen commented Jun 6, 2016

Released in v1.11.0.

@japj japj deleted the japj:biml branch Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.