New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong order in parameters #6

Closed
cunha17 opened this Issue Jul 31, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@cunha17

cunha17 commented Jul 31, 2015

Version: "roundcube/plugin-installer": "dev-master"

I found out a small bug in Roundcube/Composer/PluginInstaller.php at line 168:
$constraint = new VersionConstraint($version, $operator);

Since the constructor of VersionConstraint declares its parameters as $operator and $version, in this order, this call causes an error when validating "extras". The fix is simple, just change the order at line 168 to comply with the constructor:
$constraint = new VersionConstraint($operator, $version);

Regards,

Cristiano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment