Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Disable PHP notices + check for installer script on login page

  • Loading branch information...
commit 330127a6123e45a96132910ddd991c37b2ed5953 1 parent ce102f2
@thomascube thomascube authored
Showing with 21 additions and 4 deletions.
  1. +12 −1 index.php
  2. +1 −0  installer/index.php
  3. +8 −3 installer/welcome.html
View
13 index.php
@@ -2,7 +2,7 @@
/*
+-----------------------------------------------------------------------+
| RoundCube Webmail IMAP Client |
- | Version 0.1-20071210 |
+ | Version 0.1-20080302 |
| |
| Copyright (C) 2005-2007, RoundCube Dev. - Switzerland |
| Licensed under the GNU GPL |
@@ -240,6 +240,17 @@
// not logged in -> show login page
if (empty($USER->ID))
{
+ // check if installer is still active
+ if (is_file('./installer/index.php'))
+ $OUTPUT->add_footer('
+ <div style="background:#ef9398; border:2px solid #dc5757; padding:0.5em; margin:2em auto; width:50em">
+ <h2 style="margin-top:0.2em">Installer script is still accessible</h2>
+ <p>The install script of your RoundCube installation is still stored in its default location!</p>
+ <p>Please <b>remove</b> the whole <tt>installer</tt> folder from the RoundCube directory because
+ these files may expose sensitive configuration data like server passwords and encryption keys
+ to the public. Make sure you cannot access the <a href="./installer/">installer script</a> from your browser.</p>
+ </div>');
+
$OUTPUT->task = 'login';
$OUTPUT->send('login');
exit;
View
1  installer/index.php
@@ -26,6 +26,7 @@
<?php
+ ini_set('error_reporting', E_ALL&~E_NOTICE);
ini_set('display_errors', 1);
$docroot = realpath(dirname(__FILE__) . '/../');
View
11 installer/welcome.html
@@ -10,8 +10,12 @@
<ul>
<li>PCRE (perl compatible regular expression)</li>
<li>Session support</li>
- <li>libiconv (recommended)</li>
- <li>mbstring (optional)</li>
+ <li>Sockets enabled</li>
+ <li>Libiconv (recommended)</li>
+ <li>OpenSSL (recommended)</li>
+ <li>FileInfo (optional)</li>
+ <li>Multibyte/mbstring (optional)</li>
+ <li>Mcrypt (optional)</li>
</ul>
</li>
<li>php.ini options:
@@ -19,12 +23,13 @@
<li>error_reporting E_ALL &amp; ~E_NOTICE (or lower)</li>
<li>file_uploads on (for attachment upload features)</li>
<li>session.auto_start needs to be off</li>
+ <li>magic_quotes_gpc off</li>
</ul>
</li>
<li>A MySQL or PostgreSQL database engine or the SQLite extension for PHP</li>
<li>An SMTP server (recommended) or PHP configured for mail delivery</li>
</ul>
-<input type="submit" value="START" />
+<input type="submit" value="START INSTALLATION" />
</form>
Please sign in to comment.
Something went wrong with that request. Please try again.