iil_C_Sort wrongly parses response from courier imap #1713

Closed
rcubetrac opened this Issue Aug 18, 2008 · 4 comments

1 participant

@rcubetrac

Reported by chugadie on 18 Aug 2008 23:24 UTC as Trac ticket #1485283

this code assumes that the server returns messages all on one line

   881     do {
   882         $line = chop(iil_ReadLine($fp, 1024));
   883         if (iil_StartsWith($line, '* SORT')) {
   884             $data .= ($data?' ':'') . substr($line, 7);
   885     } while ($line[courier imap server does not, it breaks up the response without reprinting the * SORT prefix, then finally it sense the line that begins with 's OK'...

This code properly sorts my inbox of over 5,000 messages both date up and down.

881 do {
882 $line = chop(iil_ReadLine($fp, 8096));
883 if (iil_StartsWith($line, '* SORT')) {
884 $data .= ($data?' ':'') . substr($line, 7);
885 //@@CUSTOMIZED
886 } else {
887 if ($line0;



My) != 's')
   888             $data .= $line;
   889         }
   890     } while ($line[0]!='s');

Migrated-From: http://trac.roundcube.net/ticket/1485283

@rcubetrac

Milestone changed by @alecpl on 19 Aug 2008 06:39 UTC

later => 0.2-beta

@rcubetrac

Comment by gav on 27 Aug 2008 23:38 UTC

This did not work for my Courier IMAP server. I have not yet done a tcpdump to trace it, but load times were not at all improved.

@rcubetrac

Comment by @alecpl on 9 Oct 2008 09:48 UTC

Fixed in 7ae46f2.

@rcubetrac

Status changed by @alecpl on 9 Oct 2008 09:48 UTC

new => closed

@rcubetrac rcubetrac closed this Oct 9, 2008
@rcubetrac rcubetrac added this to the 0.2-stable milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment