New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bare-bones STARTTLS support to IMAP #1714

Closed
rcubetrac opened this Issue Aug 19, 2008 · 7 comments

Comments

Projects
None yet
1 participant
@rcubetrac
Copy link

rcubetrac commented Aug 19, 2008

Reported by chugadie on 19 Aug 2008 15:07 UTC as Trac ticket #1485284

This isn't very good, but it gets the job done. Adds starttls support to the iil_Connect function in program/lib/imap.inc This patch could add some more error handling, and maybe section off the actual stream_* php-5 methods into another function in the imap lib file.

Migrated-From: http://trac.roundcube.net/ticket/1485284

@rcubetrac

This comment has been minimized.

Copy link

rcubetrac commented Aug 21, 2008

Comment by dan on 21 Aug 2008 09:13 UTC

fixed? #1484667 5bc0ab1

@rcubetrac

This comment has been minimized.

Copy link

rcubetrac commented Sep 10, 2008

Comment by chugadie on 10 Sep 2008 13:33 UTC

The problem with changeset 1031 is that it only distinguishes the name tls from ssl. The names are practically synonymous with each other, I only used the distinction as a flag for the rest of the "STARTTLS" command functionality. Changeset 1031 would help the configurations remain separate, but it is not full "STARTTLS" functionality.

Some IMAP servers (like mine) don't encrypt the entire TCP connection, but they do start and SSL handshake when they receive the command STARTTLS. (Capabilities for this are specified by EHLO)

My patch looks for the STARTTLS capability and tries to send the STARTTLS command when the configuration parameter is "tls" as opposed to "ssl" (I just invented the difference between those two for my own settings and testing. Then the patch uses PHP5's socket encryption techniques to encrypt the remainder of the IMAP conversation.

@rcubetrac

This comment has been minimized.

Copy link

rcubetrac commented Apr 14, 2009

Comment by ali on 14 Apr 2009 01:26 UTC

Hi,

While facing the same STARTTLS issue, I've found on dev list''',,![that Francis Russell has submitted a patch for the same purpose.

Maybe STARTTLS support could be now part of trunk?

**1''' [[http:_lists.roundcube.net/mail-archive/dev/2009-01/0000016.html](http:_lists.roundcube.net/mail-archive/dev/2009-01/0000013.html][[BR]]
![2])[[[BR]([BR]]

Regards,

--)]
Ali Mdidech

@rcubetrac

This comment has been minimized.

Copy link

rcubetrac commented Apr 14, 2009

Owner changed by ali on 14 Apr 2009 01:26 UTC

=> none

@rcubetrac

This comment has been minimized.

Copy link

rcubetrac commented Apr 14, 2009

Comment by @alecpl on 14 Apr 2009 07:36 UTC

Applied in f86e8f5 with small modification which allows to skip STARTTLS when we don't need it.

@rcubetrac

This comment has been minimized.

Copy link

rcubetrac commented Apr 14, 2009

Status changed by @alecpl on 14 Apr 2009 07:36 UTC

new => closed

@rcubetrac

This comment has been minimized.

Copy link

rcubetrac commented Apr 14, 2009

Milestone changed by @alecpl on 14 Apr 2009 07:36 UTC

later => 0.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment