Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken encoding in atached html and htm files #1986

Closed
rcubetrac opened this issue Dec 5, 2008 · 17 comments
Closed

Broken encoding in atached html and htm files #1986

rcubetrac opened this issue Dec 5, 2008 · 17 comments

Comments

@rcubetrac
Copy link

@rcubetrac rcubetrac commented Dec 5, 2008

Reported by simplexe on 5 Dec 2008 13:13 UTC as Trac ticket #1485607

Hi
When I send messages with embedded html file on the Russian encoding, then at the opening of RC she displayed incorrectly. Versions 0.2 to svn.
I apologize for my English.

Migrated-From: http://trac.roundcube.net/ticket/1485607

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 5, 2008

Comment by @alecpl on 5 Dec 2008 16:48 UTC

Attach sample message, please.

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 5, 2008

Owner changed by @alecpl on 5 Dec 2008 16:48 UTC

=> none

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 5, 2008

Comment by tensor on 5 Dec 2008 23:24 UTC

Confirming the issue with the attached example file. The file is in fact UTF-8, but RC (or my Courier) treats it as being latin1.

I have sent it through Thunderbird to myself.
Thunderbird have correctly set the headers for attachment part:

Content-Type: text/html; charset=UTF-8;
 name="1.htm"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline;
 filename="1.htm"
@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 15, 2008

Milestone changed by @alecpl on 15 Dec 2008 09:42 UTC

later => 0.2-stable

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 16, 2008

Comment by @alecpl on 16 Dec 2008 12:37 UTC

Fixed in 781f341. There was no attachment charset set when message was sent.

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 16, 2008

Status changed by @alecpl on 16 Dec 2008 12:37 UTC

new => closed

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 17, 2008

Comment by simplexe on 17 Dec 2008 12:17 UTC

Replying to alec:

Fixed in 781f341. There was no attachment charset set when message was sent.
no work :(

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 17, 2008

Status changed by simplexe on 17 Dec 2008 12:17 UTC

closed => reopened

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 17, 2008

Comment by @alecpl on 17 Dec 2008 14:06 UTC

This will work only for newly created messages. The change adds charset definition to attachment part. Rouncube relies on BODYSTRUCTURE, and has no charset detection method (Thunderbird uses chardet)., so currently is not possible to detect attachment character set if it's not specified in header.

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 18, 2008

Comment by simplexe on 18 Dec 2008 05:37 UTC

Replying to alec:

This will work only for newly created messages. The change adds charset definition to attachment part. Rouncube relies on BODYSTRUCTURE, and has no charset detection method (Thunderbird uses chardet)., so currently is not possible to detect attachment character set if it's not specified in header.
i know. i create new message and add attachment html. letter headers:

Content-Type: text/html; charset=UTF-8;
 name="1.htm"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline;
 filename="1.htm"

and body html from roundcube create as utf8, but attachment part encoding as latin1.

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 18, 2008

Comment by @alecpl on 18 Dec 2008 07:31 UTC

So, as you see, headers are set correctly now. What returns your imap server for BODYSTRUCTURE command?

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Dec 18, 2008

Comment by simplexe on 18 Dec 2008 10:36 UTC

<title>RoundCube Mail</title>
@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Jan 22, 2009

Comment by simplexe on 22 Jan 2009 07:57 UTC

hi!
there is progress in the work?

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented Jan 22, 2009

Comment by @alecpl on 22 Jan 2009 09:25 UTC

Show imap's BODYSTRUCTURE reply for that message. Also attach the message. It works for me. Charset in attachment Content-Type header is set correctly to UTF-8.

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented May 8, 2009

Comment by @alecpl on 8 May 2009 09:10 UTC

Attach the whole message source, please.

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented May 8, 2009

Comment by @alecpl on 8 May 2009 09:12 UTC

It maybe a BOM issue fixed in 3bde305. Closing now.

@rcubetrac

This comment has been minimized.

Copy link
Author

@rcubetrac rcubetrac commented May 8, 2009

Status changed by @alecpl on 8 May 2009 09:12 UTC

reopened => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.