Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
installer checks date.timezone for no reason #2284
Reported by Atropos on 22 Jul 2009 02:46 UTC as Trac ticket #1485989
Changeset 2752 includes a patch to the installer that checks to see if date.timezone was set. This was an attempt to fix a problem with timestamps in RC logs not matching timezone of timestamps in Apache logs. ('Different Timezone offsets in my RoundCube log') did not mention any other reasons the patch may be needed. It did not fix the problem according to the person who experienced that issue. This patch does create a problem with users who want to install RC on web hosts who have a default installation of PHP that does not specify a timezone using date.timezone. I suggest backing out the patch.
Keywords: date.timezone installer
Comment by Atropos on 22 Jul 2009 18:33 UTC
Replying to rosali:
Why not have the installer determine a "server timezone" offset from GMT and store that as a config variable, then patch write_log to apply this offset? That is how the user date functions work after all. Apparently rosali can't trust PHP to use the same timezone for the duration that Roundcube is executing, or perhaps in a mod_php/FastCGI environment PHP's timezone is changed.
Comment by @till on 31 Jul 2009 00:55 UTC
Again, they should set it in
[ Or whatever is applicable. ]
Re: your issue
I don't know enough about your environment. I'm pretty sure it's the same timezone issue as before. You can ping me via email and we'll try to resolve this.