Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer checks date.timezone for no reason #2284

Closed
rcubetrac opened this issue Jul 22, 2009 · 11 comments

Comments

@rcubetrac
Copy link

commented Jul 22, 2009

Reported by Atropos on 22 Jul 2009 02:46 UTC as Trac ticket #1485989

Changeset 2752 includes a patch to the installer that checks to see if date.timezone was set. This was an attempt to fix a problem with timestamps in RC logs not matching timezone of timestamps in Apache logs. ('Different Timezone offsets in my RoundCube log') did not mention any other reasons the patch may be needed. It did not fix the problem according to the person who experienced that issue. This patch does create a problem with users who want to install RC on web hosts who have a default installation of PHP that does not specify a timezone using date.timezone. I suggest backing out the patch.

Keywords: date.timezone installer
Migrated-From: http://trac.roundcube.net/ticket/1485989

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 22, 2009

Comment by @alecpl on 22 Jul 2009 06:19 UTC

Roland has been

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 22, 2009

Milestone changed by @alecpl on 22 Jul 2009 06:19 UTC

later => 0.3-stable

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 22, 2009

Comment by @till on 22 Jul 2009 08:51 UTC

Roland has been ... ?

Btw, you could use .htaccess to set date.timezone, or you tell your webhost that they have a mis-configured PHP.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 22, 2009

Owner changed by @till on 22 Jul 2009 10:52 UTC

=> till

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 22, 2009

Comment by rosali on 22 Jul 2009 14:38 UTC

Till, it looked like the setting of the timezone in php fixed different timezone offsets between RC and apache logs. But since a few days the weird issue started again.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 22, 2009

Comment by Atropos on 22 Jul 2009 18:33 UTC

Replying to rosali:

Till, it looked like the setting of the timezone in php fixed different timezone offsets between RC and apache logs. But since a few days the weird issue started again.

Why not have the installer determine a "server timezone" offset from GMT and store that as a config variable, then patch write_log to apply this offset? That is how the user date functions work after all. Apparently rosali can't trust PHP to use the same timezone for the duration that Roundcube is executing, or perhaps in a mod_php/FastCGI environment PHP's timezone is changed.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 30, 2009

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 31, 2009

Comment by @till on 31 Jul 2009 00:55 UTC

Again, they should set it in .htaccess - instead of editing the installer. Regardless, they could also email their hosting company to fix this.

php_value date.timezone Europe/Berlin

[ Or whatever is applicable. ]

Re: your issue

I don't know enough about your environment. I'm pretty sure it's the same timezone issue as before. You can ping me via email and we'll try to resolve this.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Jul 31, 2009

Comment by @alecpl on 31 Jul 2009 11:19 UTC

Again. This shouldn't be required setting. We should move this to some "Recommended" section.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Aug 27, 2009

Comment by @alecpl on 27 Aug 2009 13:38 UTC

Fixed in 11e670d.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Aug 27, 2009

Status changed by @alecpl on 27 Aug 2009 13:38 UTC

new => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.