extended addressbook patch #2592

Closed
rcubetrac opened this Issue Dec 18, 2009 · 17 comments

Comments

Projects
None yet
1 participant

Reported by bbeveridge on 18 Dec 2009 03:29 UTC as Trac ticket #1486377

Hi All,
Here is a patch to extend the current addressbook, it adds commonly used extra fields such as:
work_number
home_number
fax_number
mobile_number
title
company
work_address
home_address
note

it has been applied against revision 3183
it also has vcard import and export with these extra fields according to the vcard standard.

Currently it only has en_US labels
It also includes the modifications to all the initial and updates for SQL.

Keywords: addressbook, extended
Migrated-From: http://trac.roundcube.net/ticket/1486377

Comment by osos on 18 Dec 2009 07:07 UTC

Thank you.

Working great here. Exactly what I have been waiting for.

Milestone changed by osos on 18 Dec 2009 07:07 UTC

later => 0.4-beta

Milestone changed by @alecpl on 26 Feb 2010 20:45 UTC

0.4-beta => 0.5-beta

Comment by osos on 24 Apr 2010 10:59 UTC

Seems not to apply smoothly to 0.4-beta!

Alec: Any changes this could be added to 0.4-stable ?

At least I think the "note"-field should be added, to be able to smoothly convert from Squirrelmail addressbook.

Comment by toddtrann on 4 May 2010 19:12 UTC

I went through the old patch, and applied all by hand to current svn trunk, and then made a new patch. Should now apply cleanly.

However, I did not test functionality, only updated patch.

Todd

Comment by toddtrann on 4 May 2010 20:05 UTC

Now test results:

[Click on contact, enter data into new fields, save form, view data
OK Click on contact again, change data, save, view data
[Export contact that does not contain new fields
Failed Export contact with data in new fields (new data does not show up in vCard file??)

I could not test import, there were other errors not related to this patch.

Todd

Comment by toddtrann on 4 May 2010 20:33 UTC

And finally with respect to LDAP, this works. Once I put in all the correct LDAP field names into the config file, I can save and view all of the new fields.

When you combine this patch with the patch from ticket #1486682 then you have drag and drop copying between address books working: database to LDAP, and also reverse. Works great, all fields were copied over.

Todd

Comment by toddtrann on 4 May 2010 22:55 UTC

Sorry for multiple uploads, I checked out a fresh copy from svn and my previous patch would not apply, here's a better one against r3593/svn.

Note that vCard export still isn't working for me, another set of eyes on it would be good, I can't see the problem.

Comment by mattrude on 13 May 2010 13:19 UTC

This patch seems to be working well on d17a7fe. I will be nice when it starts working with LDAP, but I'm sure that will happen soon.

Comment by toddtrann on 13 May 2010 15:29 UTC

Matt, it is working with LDAP for me. Did you test it and its not working for you? Note that you have to fill in the blanks for the LDAP fields where the new data is stored in main.inc.php since I didn't put any default ones. I didn't think they were standardized enough.

Comment by mattrude on 13 May 2010 22:14 UTC

Im sorry it is working, I just didn't fill in the config file. I am having a problem with the Fax field, but that may be my fault.

Here's my current config if this helps anyone.

{{
'name_field' => 'cn',
'email_field' => 'mail',
'surname_field' => 'sn',
'firstname_field' => 'givenName',
'work_number_field' => 'telephoneNumber',
'home_number_field' => 'homePhone',
'fax_number_field' => 'Fax',
'mobile_number_field' => 'mobile',
'title_field' => 'title',
'company_field' => 'o',
'work_address_field' => 'street',
'home_address_field' => 'homePostalAddress',
'note_field' => 'description',
}}

Comment by rediculum on 7 Oct 2010 12:31 UTC

Check out #1487039 for inetorgperson LDAP patch in en_US and de_CH

Comment by bagu on 1 Nov 2010 10:57 UTC

There is a problem with :
foreach ($this->raw[as $entry) {
if ($entry'type'[== "HOME"){
$this->home_address = $entry0;
}
elseif ($entry[== "WORK") {
$this->work_address = $entry0;
}
}
foreach ($this->raw[as $entry) {
if ($entry'type'[== "HOME"){
$this->home_number = $entry0;
}
elseif ($entry[== "WORK") {
$this->work_number = $entry0;
}
elseif ($entry[== "CELL") {
$this->mobile_number = $entry0;
}
elseif ($entry[== "FAX") {
$this->fax_number = $entry0;
}

When export to vcard.
Many php errors happen (foreach get invalid argument)

Comment by bagu on 17 Jan 2011 11:36 UTC

When export to vcard, when there is or other character like this, the export stop and skip the end of the contact information.
Then it go to the next contact.

Comment by @thomascube on 19 Jan 2011 17:15 UTC

Full featured address book available since 0501b63. It's not based on this patch but should satisfy the request.

Status changed by @thomascube on 19 Jan 2011 17:15 UTC

new => closed

@rcubetrac rcubetrac closed this Jan 19, 2011

Comment by bagu on 19 Jan 2011 17:22 UTC

In 0501b63 i don't see the ability to specify a work phone number and a home phone number (same for adress)

@rcubetrac rcubetrac added this to the 0.6-beta milestone Mar 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment