Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert image in HTML signature #3917

Closed
rcubetrac opened this issue Sep 6, 2012 · 17 comments
Closed

Insert image in HTML signature #3917

rcubetrac opened this issue Sep 6, 2012 · 17 comments

Comments

@rcubetrac
Copy link

@rcubetrac rcubetrac commented Sep 6, 2012

Reported by jasb on 6 Sep 2012 08:52 UTC as Trac ticket #1488676

Howdy,

Would it be possible to add an image to the HTML signature? Maybe changing the text editor to FCK or enable the button is tinny editor supports it?

Thanks in advanced,
Jorge,

Migrated-From: http://trac.roundcube.net/ticket/1488676

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Sep 6, 2012

Comment by bes internal on 6 Sep 2012 09:26 UTC

you can insert a picture as html (img src)
a bad idea to give a reference to a closed or local resource which is often roundcube installation

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Sep 6, 2012

Comment by @alecpl on 6 Sep 2012 10:15 UTC

There's one undocumented feature of TinyMCE - it's possible to drag&drop an image into the editor area. Maybe not supported in all browsers, I tested with Firefox. So, you can add an image to the signature. But to make this working in all email clients after the message has been sent, we need #1488502 to be implemented.

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Sep 6, 2012

Comment by jasb on 6 Sep 2012 19:03 UTC

Hi Alec,

Ya, the drag & drop works, on my case, on last GIT today, the save doesn't work when inserting a image, and maybe 'cause of that on new messages nothing is added.

I'll track the trac number!

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Feb 1, 2013

Comment by @thomascube on 1 Feb 2013 14:12 UTC

This seems to be a frequently asked feature and we should find a proper way to upload and store images with the signature. Maybe by adding a an additional column to the identities table or by saving them as data: urls in the HTML signature block. When sending a message, the data: urls should be extracted as inline message parts and referenced with cid:.

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Feb 1, 2013

Milestone changed by @thomascube on 1 Feb 2013 14:12 UTC

later => 1.0-beta

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Feb 1, 2013

Comment by @alecpl on 1 Feb 2013 14:17 UTC

Data URIs are already extracted into inline attachments. All we need is images handling in identity form and storing them in data URIs.

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Jul 5, 2013

Comment by cebe on 5 Jul 2013 15:04 UTC

I add my vote. But with a max file size (15ko for example) !

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Nov 25, 2013

Milestone changed by @alecpl on 25 Nov 2013 08:22 UTC

1.0-beta => 1.1-beta

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Jan 11, 2014

Comment by seaq on 11 Jan 2014 22:29 UTC

Hi, I was wondering if everyone is aware of the option to just copy the image signature in the email body??

Let me explain (with a caveat)

When I compose a new message, I can copy my image signature to the email just dragging the image or using ctrl+c and ctrl+v. It gets appropriately encoded, however the email adds a html tag like this:

However, the ideal situation is just use the signature section from the identities tab. Sadly it doesn't works using the same way, if I drag or copy the image into the signature box, the image gets incorrectly encoded when I click the save button. It seems the newline characters damage the encoding.

Can be this fixed by the devs?

Thanks in advance

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Jun 29, 2014

Comment by @alecpl on 29 Jun 2014 08:17 UTC

@seaq: it works for me. Open a separate ticket providing more info: browser, image type, check browser console for errors, logs, etc.

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Jun 29, 2014

Comment by jasb on 29 Jun 2014 11:20 UTC

Alec,

Same happens to me in todays git head, I insert an image, and after that I just see the base64 encoded string, and on a new message there's nothing there,

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Jun 29, 2014

Comment by @alecpl on 29 Jun 2014 14:38 UTC

Please, open a new ticket with more info. I'm closing this one. Image upload is possible in html signature editor since todays commit 3cc1afa.

@rcubetrac
Copy link
Author

@rcubetrac rcubetrac commented Jun 29, 2014

Status changed by @alecpl on 29 Jun 2014 14:38 UTC

new => closed

@vasyugan
Copy link

@vasyugan vasyugan commented Apr 11, 2016

Images which are included in signatures are pointing to an external address, which makes them not appear in most mail clients, which by default don't display external images. Images added to signatures should be converted into attachments, as thunderbird does.

@alecpl
Copy link
Member

@alecpl alecpl commented Apr 11, 2016

@vasyugan, we have #4988 for this.

@Namudril
Copy link

@Namudril Namudril commented Apr 15, 2016

If you are not able or do not want to keep images for your signature on a separate storage, you can use inline images in base64, i.e.:
<img src="data:image/gif;base64,R0lGODlhyAAyAOfsAAFd/gFd/wJd/gNe/gRf/gVf/gZg/gdg/ghh/gli/gpi/gtj/gxk/g1k/g5l/g9m/hBm/hFn/hJn/hNo/hRp/hVp/hZq/hdr/hhr/hls/hpt/htt/hxu/h1u/h5v/h9w/iBw/iFx/iJy/iNy/iRz/iV0/iZ0/id1/ih1/il2/ip3/it3/ix4/i15/i55/jB6/jF7/jJ8/jN8/jR9/jV+/jZ+/jd//jiA/jmA/jqB/juB/jyC/j2D/j6D/j+E/kCF/kGF/kKG/kOH/kSH/kWI/kaI/keJ/kmK/kqL/kuM/kyM/k2N/k6O/k+O/lCP/lGP/lOR/lSR/lWS/laT/leT/liU/lmV/lqV/luW/lyW/l2X/l+Y/mCZ/mGa/mKa/mOb/mSc/mWc/med/mie/mmf/mqf/myh/m2h/m6i/m+j/nCj/nKk/nSm/nWm/nan/neo/nio/nmp/nqq/nuq/nyr/n2r/n6s/n+t/oCt/oGu/oKv/oOv/oSw/oWw/oax/oey/oiy/oq0/ou0/oy1/o22/pC3/pG4/pK5/pO5/pS6/pW7/pa7/pe8/pi9/pm9/pq+/pu+/p3A/p7A/p/B/qDC/qLD/qPE/qTE/qXF/qbF/qfG/qjH/qnH/qrI/qvJ/qzJ/q3K/q/L/rHM/rLN/rPO/rTO/rXP/rbQ/rfQ/rjR/rnS/rrS/rzT/r7V/r/V/sDW/sHX/sLX/sPY/sTZ/sXZ/sba/sfa/sjb/snc/src/svd/sze/s3e/s7f/s/g/tDg/tHh/tLh/tPi/tTj/tXj/tbk/tfl/tjl/tnm/trm/tzo/t3o/t7p/t/q/uDq/uHr/uLs/uPs/uTt/uXt/ufv/ujv/unw/urx/uvx/uzy/u3z/u7z/u/0/vD0/vH1/vL2/vP2/vT3/vX4/vb4/vf5/vj6/vn6/vr7/vv7/vz8/v39/v7+/v///////////////////////////////////////////////////////////////////////////////yH5BAEKAP8ALAAAAADIADIAAAj+ANkJHEiwoMGDCBMqXMiwocOHECNKnEixosWLGDNq3Mixo8ePIEOKHEmypMmTKFOqXMmypcuXMGPKnEmzps2bOHPq3Mmzp8+fQIMKHUq0qNGjSJMqhSkpx7qlNXNpGBIU14EArqDStBKABs0yBl7gQojNQ4AAwrTOPBEgzkxoAM6OSGfQnI6zAeiqhYmOQIBXMzXhDVDLoJcADwIowGntywMTt2SqciEhU8NhARacm9klgIqzeAoSCkBATYATGs3pCfHAF8ZtIwIICDDDYCkON1C28ltAQ8NKAYxQVGeIw4RHGtVZCCCpQ4AOetmRmj2ISwAmA6OlyEEQ3IsWDM3+CQlg4MELg+mCNHnoJIAPaQESFORlIMCHg4ouhKAhzuCLLwnVkoEK2dQVWxTWLNAQGwHkgRA4a1iwwScGldMEXg0UdIsTFlTQCES1nNVMG2eBItAvDFy3TgYBzDFQFQGEQJAjAUDAkBkBcJAMEAEYJEoAFzgUYgHQ4BKADAW1F0EuBrkxGBTnjGOMIkhoEJ9AyODAQCkCdYPBWYUYdEkAB1yTCRENIRHAKAddswJeAnhRijXqfFPKWS4kcxZBgsyG1yYPxREACOwgE5cM6piDQgAeZINZAJ0IVI1flg00nhYL2QJAAbqkM0GPBI1yFhgOHXaFdwGQQpAnZ8FSUC/+eCaTyWBnOYBIAA6wgw0HZ9kgEBwBlBDAFAY9EYAUtUDgKkNsJWPQOTkE8IUisdF6VgbToLOnQJuQd4k3TqbwUAoBbCEQFWcxUkcAA8zCjiJnFSPQIkcS5MxsrCzEIxzspLKtQIwMcBYmA21CARIICeuHDS0SFInAAURCUC1XIcCMruQVwIALZTDDKpJK4GUAOt00IEUjAZBgEK9LKECHQw4E4E1BspxlBDrsNKPYGRwQcMFZprAzzbbmbBAAJQJ9Q5pDypyFNDvOJJBZXHcIhMVZBbLT3iQEWefBUwn5EgAF37DTA9bsmINjETQEwCQ7xyhw1lNPnNCHs+zIjUD+AHYMtA4fAMihxaDlCJTJ3gF4IVAuATBQEB0BhPFJABJYctYziABADC1nXVNQfQGgAXYqKickMM4D/XLtNgKREwACA1ESwBEC/QjqmDsMhEwAGzh0yFnBDAQIXjXotWgA6gjEqzSSTnGWiwqtEYAe7GCiWACX9NK2EOGIEMA07IzzAl7gsPOltQtoMtA0TATARs5yB4IOiSCwuMqvAUxQUMiHmMWJ0m6LwXrEITCCEaQCASDDQGLBgPUkJGbOGAgqEhOASgwkFAHwlUCGEABUFMosAhBI+9QnEOuYwSFqCkDZBJIOGLGgGgPxSwDAJjViSIMPFAyAvBTiggAggxn+EegBHwYThs3ErHBZCEAMruIsQbVBBApgSwDAwI1vyMIMCihAIgbyB8TMIAAoeMZVuMEObVBgWAXxHozWs4646CEAthBItHAAjmh4QgkowEEAgrANZbyhACSwhkLG4wVu/KILAJDAWbohEGJ86mnsiEAAoGGIBjQASAJBYNb2MDYYNiRFAUDdQJgRHXYgbhwCMRZeFiCFAKyAIXIjhgkg0IxxTGEBPfCgQASWDukZoBcgCEAo2FGM7w1kVrSawS4IUo6ruId1EAgAM4DBMAcooyB7S4ABLpa3+PxgINYbDAZW8Qha7YAaC1lFXPAigmHIbRndSMQljZA8gUjyLFr+ANZ52BGzXPQiCbgqjEMKIBuGVEsXAtHGFSRwATNIQ018MOhZFgAYhEhyB2c5BDt8EIAxsOMcoSRIJWCwAA44QRT1FEg53hiALmyGHUsYjAVkYRCCBqAMA2GLAJY5kDhYkgeJ6A878GABBuRgEilViCdUYAAT6KE/KcTLEFYokD4w4AaeYIcYAqAEgTgPLyX4BUTEYIAzMGQMZ+mdQQwVgGsuhBUgYEEvFBLTs6ihqq/7hScs4JBx8GE5AggEQY4RAgW0wA6sM4j3GODJdzmAECeZhhAMUAEkXAJsCDFCAMyqqycggAR8EKpHsPGCB2jUIFtFkkaEUYEJ9E0g2FCP5FnS4JDxBCACp5DIIiIAiZ+wSGIxqcZVICsSWrAAAVlAZUNiAAEuME8tLYjjiUQkkznI5rl7wYkZEKAHZ3yDCAHgwUysJN7s5sQcUBjMAAQaEyRgIBbm1ck6JDGDA5AgaPHNr373y9/++ve/AA6wgAdM4AIb+MAITrCCF8zgBjv4wRCOsIQnTOEKW7ghAQEAOw==" alt="" border="0" />
You can encode your image, using any "online image to base64 encoder" you like.

@alecpl
Copy link
Member

@alecpl alecpl commented Apr 15, 2016

You can also drag-n-drop the image to the editor and it will be base64-encoded automatically ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.