Empty message body #3961

Closed
rcubetrac opened this Issue Oct 12, 2012 · 16 comments

1 participant

@rcubetrac

Reported by zamri on 12 Oct 2012 03:24 UTC as Trac ticket #1488750

RC doesn't show the message body correctly. Gmail can show it correctly and in the source, I can see there is texts for the body.

I attached the .eml file for testing.

Keywords: empty,body
Migrated-From: http://trac.roundcube.net/ticket/1488750

@rcubetrac

Comment by zamri on 12 Oct 2012 03:27 UTC

The theme used is Larry.

@rcubetrac

Comment by @alecpl on 12 Oct 2012 06:40 UTC

The message contains multipart/alternative subpart with text/plain and text/html part. As you can see in the source text/html part is empty. I suppose we could try to workaround such situations and use text/plain. You should be able to see this message when you disable html.

@rcubetrac

Severity changed by @alecpl on 12 Oct 2012 06:40 UTC

critical => normal

@rcubetrac

Milestone changed by @alecpl on 12 Oct 2012 06:40 UTC

later => 0.9-beta

@rcubetrac

Comment by @alecpl on 12 Oct 2012 10:10 UTC

Fixed in 5f40958

@rcubetrac

Status changed by @alecpl on 12 Oct 2012 10:10 UTC

new => closed

@rcubetrac

Comment by zamri on 13 Oct 2012 08:57 UTC

Ok I got it. I've tested it by editing rcube_message.php with your fix:

// skip empty parts
if (!$sub_part->size)
continue;

Although the formatting is text-only but at least this workaround works.

Thx alec.

@rcubetrac

Comment by zamri on 31 Oct 2012 04:08 UTC

I got a complaint from a user that she got an empty message after I applied the fix. here I attached the source beginning with the content-type:

Content-Type: multipart/mixed; boundary="=mixed 0004233748257AA0="

--=mixed 0004233748257AA0=
Content-Type: multipart/alternative; boundary="=alternative 0004233848257AA0="

--=alternative 0004233848257AA0=
Content-Type: text/plain; charset="US-ASCII"

--=alternative 0004233848257AA0=
Content-Type: text/html; charset="US-ASCII"

--=alternative 0004233848257AA0=--
01140912032287KOLEJ SHAHPUTRA ( GASC SDN BHD) 140920122301231713=20
0214091203911026065644 911026065644 NURRUL HIDAYAH BINT=
I 060600522185220000000675100 012
0214091203920202016222 920202016222 SITI NUR AISYAH BTE=
060500944095200000000850100 012
031409120300000200000000152520000000200000000152520000000000000000000000001=

2110148153242=20

--=mixed 0004233748257AA0=--
Dear Shafarina,

Please find attached report as per requested.

Kindly open the *.rpt file with Wordpad to view in proper format.

Moving forward, kindly email us at cimbib.cmimp@cimb.com for Direct Debit
related matters to avoid delay in response.

Thank you.

Regards,
Loo Ting Sin
Transaction Banking Malaysia - Implementation & Client Services
Corporate Banking, Treasury & Markets
Tel: +603 2084 6798 | Fax: +603 2096 1950
www.cimb.com

Connect with us on Facebook: www.facebook.com/CIMBMalaysia or follow us on
Twitter: www.twitter.com/CIMB_Assists

From:
Nana Ishak shafarina@shahputra.edu.my
To:
Loo Ting Sin tingsin.loo@cimb.com
Date:
18-10-2012 11:28 AM
Subject:
Re: Direct Debit Report - Shahputra 14/9/12

@rcubetrac

Status changed by zamri on 31 Oct 2012 04:08 UTC

closed => reopened

@rcubetrac

Comment by @alecpl on 31 Oct 2012 07:04 UTC

Please, attach complete message source because this doesn't look valid.

@rcubetrac

Comment by zamri on 31 Oct 2012 08:01 UTC

Forget above incomplete source. See attachment. I have opened it in Thunderbird and it contains no text message but 1 gif image as an attachment. In RC, I dont see any attachment.

@rcubetrac

Comment by @alecpl on 31 Oct 2012 08:32 UTC

Ok. This is another case. The message is obviously malformed and we can assume that HTML part body is empty. Then we have an inline image related to HTML part. So, it is questionable if we should display it on the attachments list. For now, we decided to not display it, but you can open another ticket for this specific request. This is not a bug but designed behaviour.

@rcubetrac

Status changed by @alecpl on 31 Oct 2012 08:32 UTC

reopened => closed

@rcubetrac rcubetrac closed this Oct 31, 2012
@rcubetrac

Comment by zamri on 31 Oct 2012 09:01 UTC

I added feature request for that: http://trac.roundcube.net/ticket/1488783. Thx

@rcubetrac

Comment by @thomascube on 10 Nov 2012 14:34 UTC

Adjust milestone.

@rcubetrac

Milestone changed by @thomascube on 10 Nov 2012 14:34 UTC

0.9-beta => 0.8.3

@rcubetrac rcubetrac added this to the 0.8.3 milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment